Change boot() migrations method from publishes to loadMigrationsFrom … #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to work with laravel 5.4
lloy0076
reviewed
Jul 5, 2017
| @@ -40,7 +40,7 @@ public function boot() | |||
| $this->loadTranslationsFrom(realpath(__DIR__.'/resources/lang'), 'backpack'); | |||
|
|
|||
| // publish the migrations and seeds | |||
| $this->publishes([__DIR__.'/database/migrations/' => database_path('migrations')], 'migrations'); | |||
| $this->loadMigrationsFrom(__DIR__.'/database/migrations/'); | |||
There was a problem hiding this comment.
Does this break 5.3 though?
There was a problem hiding this comment.
That's why, while we're still supporting 5.3, I think it's safe to just publish the migrations. L5.4 will still run them (because they're published), it would just throw a warning. Right, @xxdalexx ?
|
Since L5.4 is obsolete and no longer supported, I'm going to close this. Sorry for taking so long @xxdalexx . Please don't let this discourage you from submitting other PRs. We've massively increased the time we spend on Backpack in 2018, so that things like this don't happen anymore. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to work with laravel 5.4