[HOT-FIX] only add the cache busting string to non internal files #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxpm
commented
Apr 12, 2024
promatik
reviewed
Apr 12, 2024
Co-authored-by: António Almeida <promatik@gmail.com>
pxpm
commented
Apr 12, 2024
promatik
approved these changes
Apr 12, 2024
pxpm
deleted the
hot-fix/only-add-the-cache-busting-string-to-non-internal-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #119
It seems the problem may be out of control for us, so the only reasonable thing we could do is to NOT append the cache busting string on 3rd party requests AKA cdn.
Requests to internalized files or relative paths still use the cache busting string.