Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate menu #161

Merged
merged 1 commit into from
Feb 22, 2024
Merged

remove duplicate menu #161

merged 1 commit into from
Feb 22, 2024

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented Feb 22, 2024

this fixes the issue reported in Laravel-Backpack/community-forum#849

@pxpm pxpm merged commit fd98511 into main Feb 22, 2024
1 check passed
@pxpm pxpm deleted the fix-vertical-dark-layout branch February 22, 2024 18:26
@nerbiz
Copy link

nerbiz commented Feb 23, 2024

Please revert these changes, as the menu is now gone on 'lg' and larger screens.
I believe it can be fixed instead by adding 'd-none d-lg-block' classes to the account dropdown menu, the one that was removed.

This proposal works on my end, but please test to be sure:

<li class="nav-item dropdown d-none d-lg-block">

pxpm added a commit that referenced this pull request Feb 23, 2024
@pxpm
Revert "Merge pull request #161 from Laravel-Backpack/fix-vertical-da…
0c2081b 
…rk-layout"

This reverts commit fd98511, reversing
changes made to 563bbdd.
@pxpm
Copy link
Contributor Author

pxpm commented Feb 23, 2024 •
edited

Please revert these changes, as the menu is now gone on 'lg' and larger screens. I believe it can be fixed instead by adding 'd-none d-lg-block' classes to the account dropdown menu, the one that was removed.

This proposal works on my end, but please test to be sure:

<li class="nav-item dropdown d-none d-lg-block">

thanks, sorry for that.
fixed in 1.2.3 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pxpm @nerbiz