Skip to content

Commit

Permalink
Fix the issue where defaults has a higher priority then the attributes (
Browse files Browse the repository at this point in the history
  • Loading branch information
crlcu authored and tshafer committed Apr 9, 2018
1 parent 623a150 commit b3a1024
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/HtmlBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function style($url, $attributes = [], $secure = null)
{
$defaults = ['media' => 'all', 'type' => 'text/css', 'rel' => 'stylesheet'];

$attributes = array_merge($attributes, $defaults);
$attributes = array_merge($defaults, $attributes);

$attributes['href'] = $this->url->asset($url, $secure);

Expand Down

2 comments on commit b3a1024

@howar31
Copy link

@howar31 howar31 commented on b3a1024 Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this issue be fixed in Laravel 5.5 LTS?
I found this issue breaks the display of my site while upgrading Laravel from 5.2 to 5.5. And 5.5 is LTS version which should support bug fix for two years iirc.

@decadence
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Laravel follows LTS rule. This package is provided as is. You can create PR to fix this in 5.5.

Please sign in to comment.