Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update laravel docs' URL to 9.x from 8.x #21

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Update laravel docs' URL to 9.x from 8.x #21

merged 2 commits into from
Feb 18, 2022

Conversation

prashant-malla
Copy link
Contributor

Updated laravel docs' URL to the latest 9. x from 8.x

sergiuprt
sergiuprt reviewed Feb 17, 2022
View reviewed changes
Copy link

@sergiuprt sergiuprt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems OK to me although there's this branch conflict

JustinByrne
JustinByrne approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@JustinByrne JustinByrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All links checked and working.

@PovilasKorop
Copy link
Collaborator

@prashant-malla thanks a lot for the effort!

But I see the conflict in readme.md here, could you push the commit to resolve it, and then I would merge.

@prashant-malla
Copy link
Contributor Author

resolved conflicts

@PovilasKorop PovilasKorop merged commit 3b1bda9 into LaravelDaily:main Feb 18, 2022
@PovilasKorop
Copy link
Collaborator

@prashant-malla great thanks!

@PovilasKorop
Copy link
Collaborator

@prashant-malla sorry but I think you REMOVED some links that were present, see issue #22 - somehow my eyes have missed it when re-checking.

Could you add another Pull Request fixing this?

@PovilasKorop PovilasKorop mentioned this pull request Feb 18, 2022
Closed
@Esirei
Copy link
Contributor

Esirei commented Feb 18, 2022

Yea, a lot of links got removed, especially links to YouTube videos.
Also, personally, I think it'll be better to remove the 9.x part in the link, as it'll always get redirected to the latest Laravel version.
Example (https://laravel.com/docs/eloquent-mutators)

@Esirei Esirei mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiuprt sergiuprt sergiuprt left review comments

@JustinByrne JustinByrne JustinByrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prashant-malla @PovilasKorop @Esirei @sergiuprt @JustinByrne