Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Custom InfoWindow and Icon on Google Maps #24

Merged
merged 3 commits into from
Mar 10, 2022

Conversation

kikojover
Copy link
Contributor

Hi Lars, this is a great package!!
In one of my projects i need InfoWindow and custom icons on Google Map.
I've added this ability to blade template.
Hope is useful and you accept PR
Thanks for your work

@LarsWiegers
Copy link
Owner

Hi @kikojover, thx for the kind words!

Love the idea and the pr. Do you use the package only for google maps?

I would love to keep the api for both the map types ( google map and leaflet ) the same.

If you add tests for the google maps info window, I can add the version for leaflet + tests.

Sounds like a deal?

@kikojover
Copy link
Contributor Author

Sure it's a deal!! :-)
Only let me use a couple of days to add the tests, sorry, I'm a newbie in the PR World.

About your question, it's the first time I have used your package, my current project requires Google Maps, so the answer is yes, i use your package only for Google Maps (for the moment ;-)), but I hope use leaflet too in he future.

A question about PR, i must send another PR with the tests or it's possible to include it in current one? (As you told I'm a newbie ...)

Thank you.

@LarsWiegers
Copy link
Owner

Hey, you can add the tests to this pr.

@kikojover
Copy link
Contributor Author

Hi @LarsWiegers , i've added Unit tests to Google Maps :-)

@LarsWiegers LarsWiegers merged commit 1826c27 into LarsWiegers:master Mar 10, 2022
@LarsWiegers
Copy link
Owner

LarsWiegers commented Mar 10, 2022

@kikojover I have merged the changes + made a new release. Thank you for adding the new functionality and creating the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants