Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding keys #34

Closed
wants to merge 4 commits into from
Closed

Excluding keys #34

wants to merge 4 commits into from

Conversation

LarsWiegers
Copy link
Owner

@LarsWiegers LarsWiegers commented Apr 6, 2023

Introduces the possibility to exclude keys via config or parameter to the command.

@LarsWiegers LarsWiegers added the enhancement New feature or request label Apr 6, 2023
@LarsWiegers LarsWiegers self-assigned this Apr 6, 2023
@LarsWiegers LarsWiegers linked an issue Apr 6, 2023 that may be closed by this pull request
Copy link

@jhm-ciberman jhm-ciberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this code in our repository, but I've checked the code changed and it looks fine to me.

Thanks! 😁

Comment on lines +9 to +11
| This package allows you to check your Laravel translations for missing
| keys, unused keys and unused translations.
| You can ignore some keys by adding them to the 'ignore' array.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is the description i used in my PR but currently the package let's you find missing keys but don't have any functionality related to "unused keys/translations". When I opened the PR I just pasted an example description without paying too much attention.
Maybe you can remove that part to better reflect the current functionality of the package.

@jhm-ciberman
Copy link

As a side comment about the code, unrelated to this PR:

I saw you use a double for loop to collect the realLines array used to compare.

I'm reading the code from my phone so maybe I'm missing something but that would make the checking to work 2 levels deep, am I right?

Maybe you can use Arr:dot($arr) built in helper (and Arr::undot) to easily collect all the keys.

@LarsWiegers
Copy link
Owner Author

Closing as this will be handled in #42

@LarsWiegers LarsWiegers closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Option to ignore certain keys?
2 participants