[FIX] Send data via JSON in call
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasley
force-pushed
the
bugfix/master/response-parse
branch
from
dae5c3e
to
390dda4
Compare
Current coverage is 100% (diff: 100%)@@ master #8 diff @@
===================================
Files 4 4
Lines 85 86 +1
Methods 0 0
Messages 0 0
Branches 3 3
===================================
+ Hits 85 86 +1
Misses 0 0
Partials 0 0
|
|
Coverage remained the same at 100.0% when pulling 390dda4b32c5a0a36d49876af807e4989677cd1b on bugfix/master/response-parse into d53fe77 on master. |
lasley
force-pushed
the
bugfix/master/response-parse
branch
from
390dda4
to
34107fb
Compare
lasley
force-pushed
the
bugfix/master/response-parse
branch
from
34107fb
to
8b94611
Compare
|
Rebased to fix conflicts; ready for review |
tedsalmon
approved these changes
Dec 27, 2016
| 'Name': self.name, | ||
| 'Password': self.password, | ||
| }) | ||
| if data is None: |
There was a problem hiding this comment.
Why not save two lines by setting the default of data to {} in the method declaration?
There was a problem hiding this comment.
We have a lint check to prevent this, but here is a little lesson in mutability 😉 :
>>> def test(key, val, map={}):
... map[key] = val
... print map
...
>>> test('a', 'a-val')
{'a': 'a-val'}
>>> test('b', 'b-val')
{'a': 'a-val', 'b': 'b-val'}
There was a problem hiding this comment.
Derppppp! I totally forgot about that. The worst part is, I think this bit one of us in the butt with a project way back when.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.