[IMP + FIX] medical_prescription_merge: Set installable and fix mail.thread field merging #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgarnau
approved these changes
Jul 6, 2017
obulkin
force-pushed
the
hotfix/10.0/medical_prescription_merge-installable
branch
from
c0b1e28
to
16bc152
Compare
* Add merge logic for the mail.thread fields message_follower_ids and message_ids, which require special handling due to an integer inverse field and SQL uniqueness constraints. These fields can be introduced to the prescription model by mail_thread_medical_prescription * Add unit tests for the new logic
obulkin
changed the title
|
I've expanded this PR to include a fix for various merge issues that can arise when the module is used in conjunction with |
obulkin
reviewed
Jul 21, 2017
Codecov Report
@@ Coverage Diff @@
## release/10.0 #215 +/- ##
================================================
+ Coverage 83.99% 84.53% +0.53%
================================================
Files 118 119 +1
Lines 2112 2192 +80
================================================
+ Hits 1774 1853 +79
- Misses 338 339 +1
|
|
LGTM thanks @obulkin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems this was previously migrated, but installable flag wasn't set.