Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][FIX] website patient form delete button #237

Conversation

woodbrettm
Copy link

@woodbrettm woodbrettm commented Aug 16, 2017

This pull request addresses the following:

  • Add deactivated filter to abstract medical entity tree views
  • Fix permission issue with medical patient diseases
  • Add confirmation prompt when users click on delete button on forms

Question

I added medical_patient_disease as a dependency to website_portal_medical_patient. Is that ok? Perhaps we should have a website_portal_medical_patient_disease module or something so that a website module can be directly mapped to the backend disease module.

The issue is associated with adding portal access to medical.patient.disease

@woodbrettm woodbrettm added this to the 10.0 milestone Aug 16, 2017
@woodbrettm woodbrettm self-assigned this Aug 16, 2017
@woodbrettm woodbrettm requested a review from lasley August 16, 2017 02:19
@woodbrettm
Copy link
Author

Tests are failing from medical_patient_disease. Will leave for now.

@lasley
Copy link
Member

lasley commented Aug 16, 2017

I'm good with the dependency. We can think about breaking it up later if we find a use case.

Weird that tests are failing... why is that not the case on release/10.0? Did you base from that?

@woodbrettm
Copy link
Author

Yup from release/10.0. I've noticed it fail on my local build in the past as well. Interesting that it's showing up now.

@lasley lasley force-pushed the bugfix/10.0/SMD-290-fix-website_portal_medical_patient-form branch from 0e11d96 to 098ca88 Compare August 16, 2017 16:20
@lasley
Copy link
Member

lasley commented Aug 16, 2017

Rebased now that #238 is merged

@codecov-io
Copy link

codecov-io commented Aug 16, 2017

Codecov Report

Merging #237 into release/10.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release/10.0     #237   +/-   ##
=============================================
  Coverage         85.17%   85.17%           
=============================================
  Files               123      123           
  Lines              2293     2293           
=============================================
  Hits               1953     1953           
  Misses              340      340

@woodbrettm
Copy link
Author

woot @lasley thanks for the fix. All checks passing now.

@lasley lasley merged commit 791ed29 into release/10.0 Aug 16, 2017
@lasley lasley deleted the bugfix/10.0/SMD-290-fix-website_portal_medical_patient-form branch August 16, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants