-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TensorVariable Init #549
Conversation
I noticed that Should I change add |
Looks good!
Yes, would be good to change that! :class:Layer is enough because we tell Sphinx that we're in the lasagne.layers namespace. The docstring change should be in a separate commit this time, i.e., not squashed into the first one. Let me know when you're done so we can merge! (github doesn't send out a notification for additional commits to a PR, only for additional comments.) |
975e9ec
to
c5ea6a4
Compare
I added references to the layer class in the doc string and squashed the commits. |
Initializer for initial hidden state (:math:`h_0`). If a | ||
TensorVariable (Theano expression) is supplied, it will not be learned | ||
regardless of the value of `learn_init`. | ||
cell_init : callable, np.ndarray, theano.shared or Layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you missed that one!
One |
a18cbf9
to
b2113b3
Compare
Sorry about that. I fixed it. |
Thanks, merging! |
Removes TensorVariable special case as discussed here: #462