Allow vector targets for column vector predictions in objectives #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes behaviour of lasagne.objectives.* for a special case: If predictions are a column vector (i.e., a matrix that is broadcastable in the second dimension) and targets are a 1D vector, implicitly turn the targets into a column vector as well. This avoids the current trap (opened in #715) that combining a network with a single output unit and a T.vector() target broadcasts predictions and targets to compare all predictions against all targets. Closes #755, but we need to discuss whether we want this. I'd argue that it seems so natural to use T.vector() for regression or binary classification targets that we should just support it. The alternative would be to warn the user to use a T.matrix() or T.col() instead.
Trapped users:
https://groups.google.com/forum/#!topic/lasagne-users/DsSY1cHCC2M
https://groups.google.com/forum/#!topic/lasagne-users/_JAgvyhpf7Q