Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial transform #7

Merged
merged 2 commits into from
Aug 19, 2015
Merged

Spatial transform #7

merged 2 commits into from
Aug 19, 2015

Conversation

skaae
Copy link
Member

@skaae skaae commented Aug 15, 2015

I created a spatial transformer layer example.

It uses some cluttered MNIST data created with deepminds generator, which i have converted to numpy format. I didn't relly get where we were supposed to put data :)

@skaae
Copy link
Member Author

skaae commented Aug 17, 2015

With Lasagne/Lasagne#361 merged I think this nearly ready.

@ebenolson: Can you help me figure out where to put the data?

@ebenolson
Copy link
Member

@skaae I think I emailed you access directions for S3? If you have trouble with that let me know, or feel free to put them up on dropbox or something else like that.

Sorry that I haven't had time to test this out yet, but I'll try to in the next couple days, or just tell me when you think it's ready and I'll merge.

@skaae
Copy link
Member Author

skaae commented Aug 19, 2015

Thanks @ebenolson, I think it's in S3 now. Can one of you try if it works?

@f0k
Copy link
Member

f0k commented Aug 19, 2015

Oops, commented on the commit diff instead of the PR diff.

@skaae
Copy link
Member Author

skaae commented Aug 19, 2015

Thanks for the comments. The -N setting is usefull. The npz file seems to be compressed already. At least the filesize does not change if I use savez_compressed and the file is ~1.0gb if i use savez.

@skaae
Copy link
Member Author

skaae commented Aug 19, 2015

I removed the wrong wget output and added the -N setting.

@f0k
Copy link
Member

f0k commented Aug 19, 2015

The npz file seems to be compressed already. At least the filesize does not change if I use savez_compressed and the file is ~1.0gb if i use savez.

That's pretty good evidence then ;) I didn't download the file to check, to not stress Eben's S3 budget.

I removed the wrong wget output and added the -N setting.

Cool! Unfortunately, all outputs seem to be gone now, including the print statements and plots...

@skaae
Copy link
Member Author

skaae commented Aug 19, 2015

ups, that sucks. I'll have to run the model again then.

@f0k
Copy link
Member

f0k commented Aug 19, 2015

I'll have to run the model again then.

You can just copy all the outputs from your previous commit. git reflog should tell you the commit ID, and chances are that it's even still on github. (Or in the email notifications sent by github for my comments.)

Let me know if you need any help.

@f0k
Copy link
Member

f0k commented Aug 19, 2015

Actually, the easiest might be to git reset --hard HEAD@{1} to get back to your previous version, then remove the wget output by hand and add the -N by hand (i.e., by editing the notebook file in a text editor). Afterwards, you can amend and force-push again.

@skaae
Copy link
Member Author

skaae commented Aug 19, 2015

cool thanks. reflog is nice :)

The plots are back.

"except:\n",
" conv = lasagne.layers.Conv2DLayer\n",
" pool = lasagne.layers.MaxPool2DLayer\n",
" print \"DNN not available, using standard (slower) conv and pool layers\"\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a myth, though. If you use the standard layers, the speed should be exactly the same, as Theano will use cuDNN both for convolution and pooling if it's available. It only makes a difference if you use strided pooling / convolution, because Theano may introduce a suboptimal gradient then (this will be fixed in future). Can you remove those checks to not spread the myth? (Again, it may be easiest to edit the file by hand. Note that you will also have to remove the Using DNN layers\n output above in this case.)

@skaae
Copy link
Member Author

skaae commented Aug 19, 2015

I removed the try/except

@f0k
Copy link
Member

f0k commented Aug 19, 2015

👍 Looks good to merge! (Didn't run it myself, though.)

@benanne
Copy link
Member

benanne commented Aug 19, 2015

This looks awesome :)

@ebenolson
Copy link
Member

Very neat, thank you!

ebenolson added a commit that referenced this pull request Aug 19, 2015
@ebenolson ebenolson merged commit fed45f6 into Lasagne:master Aug 19, 2015
@skaae skaae deleted the spatial_transform branch August 19, 2015 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants