New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile Nil to NULL #20
Conversation
hmm. it should be:
right? |
Ahh, I'm in PostgreSQL land over here and it works for me, but you are right. I'll look into this tomorrow ... |
Added fix to compile nil values like this:
What should happen with this one?
Should this return the above, true, 1 or something else? |
Hi Roman, Thanks for pitching in! I've reviewed your commits and I have two questions.
Thanks, |
Hi Roman, Disregard question 1, I had an uncommited change in my master which contaminated your branch, so sorry! |
Hi Lau, regarding your 2nd question. When I started I put the code into the With the multi method approach I can extend clojueql from the outside
That's why I changed it into a multi method. Do you think it's a huge Roman |
The performance loss should be seen in the context of database queries, so its nearly non existant. My main concern was actually the loss of clarity and I wanted to understand your motivation for designing it the way you did. Being able to plug in compiler extensions is something which could prove absolute central to ClojureQLs adoption on various backends so its something I really want designed right in the first go. You've given me some food for thought, so let me think it over and I'll get back to you. Thanks for explaining, |
r0man, I've thought it over and I like this approach, it makes it simple to plug in your own predicate compile and the loss of speed/clarity isn't enough to outweight the benefits. I've merged your changes so lets take them out for a spin and see how it goes. Thanks alot for the patch! |
Hi Lau & Ninjudd,
I added a small fix to handle nil in the compile-expr function. Before that change the following form
was generating
Now it will generate
Roman.