Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL migration: controls #602

Merged
merged 4 commits into from
Aug 7, 2023
Merged

RTL migration: controls #602

merged 4 commits into from
Aug 7, 2023

Conversation

chawes13
Copy link
Contributor

@chawes13 chawes13 commented Aug 4, 2023

Updates pagination and tab bar tests to use RTL.

Out of Scope

  • Migrating the color picker. This sees several markup changes in Routine maintenance 2023-08 #596 that will make it easier to test. No sense wasting time writing deprecated tests IMO

Author Checklist

  • Add unit test(s)
  • Update version in package.json (see the versioning guidelines)
  • Update documentation (if necessary)
  • Add story to storybook (if necessary)
  • Assign dev reviewer

@chawes13 chawes13 requested a review from josiasds August 4, 2023 16:03
josiasds
josiasds approved these changes Aug 4, 2023
View reviewed changes
test/controls/color-picker.test.js Show resolved Hide resolved
@josiasds josiasds mentioned this pull request Aug 4, 2023
Merged
52 tasks
@chawes13 chawes13 merged commit fef7199 into migrate-enzyme-to-testing-library Aug 7, 2023
2 checks passed
@chawes13 chawes13 deleted the chore/rtl-migration-controls branch August 7, 2023 15:14
chawes13 added a commit that referenced this pull request Sep 11, 2023
@josiasds @aojin @chawes13
Migrate enzyme to testing library (#586)
c3bf628 
* Set up React Testing Library

* Migrate Spinner

* convert button tests from enzyme to rtl

* remove unused imports

* remove unused import

* Update jest and set test environment to jsdom

* Bump version

* update checkbox.test.js tests

* checkbox.test.js and checkbox-group.test.js complete

* update button.test.js to use userevent

* update color-input.test.js to rtl

* remove unused imports

* update date input

* complete color-input and date-input

* complete dropdown-checkbox-group

* complete hidden input

* complete icon-input

* Fix date input issues

* RTL migration: controls (#602)

* Migrate paginator

* Add comment

* Remove unused import

* Migrate tab-bar

* RTL migration: modal (#601)

* Initial commit

* Clean up logs

* Add tests more default close interactions

* RTL migration: indicators (#600)

* Migrate loading container

* Migrate flash message

* Migrate flash message container

* Upgdate assertion

* Partial cleanup; Address code review

* Remove unecessary test

* Remove moment dependency from DateInput test

* Update ColorPicker component

* Update DropdownCheckboxGroup

* Update HiddenInput

* Update IconInput

* Update Spinner component

* Bump minor version

* Address comments

* Fix trigger on keys util

* Migrate color-picker

* RTL migration: tables (#603)

* RTL migration: labels (#607)

* partial label folder tests

* Clean up error label

* Fix input error tests

* Remove unused attribute

* Fix input label tests

* Migrate labeled-field tests

* Fixes

---------

Co-authored-by: Alex Jin <alex@launchpadlab.com>

* RTL migration: inputs (#604)

* Migrate input

* Migrate textarea

* Remove unused import

* Migrate switch

* Remove unused import

* Migrate range-input

* Migrate select

* Migrate masked input

* Migrate replace empty string value hoc

* Migrate blur dirty

* Migrate radio group input

* Migrate cloudinary uploader

* Be more explicit

* Use toHaveAttribute

* Do not reference id directly

* RTL migration: file inputs (#590)

* Migrate FileInput to RTL

* Migrate CloudinaryFileInput to RTL

---------

Co-authored-by: Conor <conor@launchpadlab.com>

* Remove enzyme

* Add act back to file input

* Avoid race conditions with act

* Update lock

* Add test for read helper

* Mock server...better

* Address uncovered line in wrap-display-name

* Remove unused default

* Add coverage for modal

* Increase dropdown select coverage

* Increase color picker coverage

* Increase color-input coverage

* Increase to-hex coverage

* Increase paginator coverage

* Increase masked input coverage

* Increase date input coverage

* Increase radio group coverage

* Improve cloudinary-uploader coverage

* Improve coverage for getEnvVar

* Improve sortable table coverage

* Improve tab-bar coverage

* Update trigger on keys

* Add comment

* Replace act with waitFor

---------

Co-authored-by: Alex Jin <alex@launchpadlab.com>
Co-authored-by: Conor Hawes <conor@launchpadlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josiasds josiasds josiasds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chawes13 @josiasds