fixes to get x86 build running

[bergstr11]

the first commit, regarding the minSdkVersion, may be specific to the x86 ABI, ,and of course this can be handled by using a custom AndroidManifest.

The second one, regarding qtdeploy.json, seems generic. The path that was constructed from the original value did not match on NDK 10 or 11, and for no prebuilt toolchain.

[LaurentGomila]

Thanks for your feedback.

I have no time for investigating this. Are you 100% sure that there is a problem, and that your fix is right? I still use this tool for new projects, and I've never had any problem with x86 nor NDK (admitedly, I usually don't bother with numbers, I just leave the defaults and it works fine).

[bergstr11]

Fact is that using the input parameters I provided, the effective path
constructed by the macros was wrong. Of course, before integrating, the fix
should be tested against other platforms, which I admittedly did not do. I
am on holiday this week, so this is about all the info I can provide

2016-08-14 23:33 GMT+04:00 Laurent Gomila notifications@github.com:

I have no time for investigating this. Are you 100% sure that there is a
problem, and that your fix is right? I still use this tool for new
projects, and I've never had any problem with x86 nor NDK (admitedly, I
usually don't bother with numbers, I just leave the defaults and it works
fine).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABkRpoU2uhtYXtOfuEY9KxGMl6xCUwXXks5qf211gaJpZM4I7gZA
.

[LaurentGomila]

I'll test your PR with all my projects, and if it doesn't break anything I'll merge it. That's the only way to make sure it will be tested on various environments ;)

[LaurentGomila]

After some tests, here are my conclusions.

1. The minimum SDK version is indeed too low, but according to this document it should be 18 (to support QtBluetooth).
2. The fix for "toolchain-prefix" seems wrong. ANDROID_TOOLCHAIN_MACHINE_NAME yields something like "arm-linux-androideabi" whereas ANDROID_ABI gives for example "armeabi-v7a". Seems to be two different things.

So you can either split this PR into two new PRs so that I can merge the version thing, or I can write and push the fix directly, given that it's just two numbers to change.

[LaurentGomila]

Ok nervermind, I made some other modifications and included the min version number fix as I couldn't test properly without it.

I close this PR, feel free to open a new one (or issue) for the "toolchain-prefix" stuff.