Add torch device interface and clean up. #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LaurentMazare ping. |
|
Actually I don't think these functions should ever fail on the C++ side so i'm not sure we should make them fallible on the rust side neither. I recently tried to add some fallible versions for the functions that I believe could fail. |
Fix example error handling
|
@LaurentMazare I also checked the ATen related parts and I didn't find any exception handling, so they seem be unwrapped safely. I changed those back to |
ehsanmok
changed the title
|
Closing this as the code has significantly diverged since then (e.g. device now include a gpu id for multi-gpu training). |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current device implementation doesn't do proper error handling, since
unsafe_torch!were used everywhere instead ofunsafe_torch_err!so for example,cuda_is_availableorDevice::cuda_if_available()shouldn't just panic due to any reason in the client code. Alsodevice_wrapped.rsdoesn't provide any safety and is redundant.This PR fixes these issues.