Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable limiting endowments with negative policy overrides #341

Merged
merged 7 commits into from
Jun 16, 2022
Merged

fix: enable limiting endowments with negative policy overrides #341

merged 7 commits into from
Jun 16, 2022

Conversation

naugtur
Copy link
Member

@naugtur naugtur commented May 27, 2022

No description provided.

@naugtur naugtur requested a review from kumavis May 27, 2022 08:18
naugtur
naugtur commented May 27, 2022
View reviewed changes
packages/core/test/mergePolicy.js
babel: {
globals: {
abc: false,
'a.b.c': false, // this is not supported
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this work? I don't think that's currently possible.

Copy link
Member

@kumavis kumavis Jun 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not interested in supporting

`a.b` true
`a.b.c` false

at this time

@kumavis
Copy link
Member

kumavis commented Jun 1, 2022

yeah i like this
can you add a failing test here https://github.com/LavaMoat/LavaMoat/blob/main/packages/core/test/globals.js

@naugtur naugtur force-pushed the naugtur-enable-negative-overrides branch from 7c128ff to 30590c4 Compare June 2, 2022 13:58
@naugtur naugtur force-pushed the naugtur-enable-negative-overrides branch from c90e197 to 5a348be Compare June 13, 2022 10:18
weizman
weizman approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@weizman weizman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool (just replace type poperty->property)

@naugtur naugtur force-pushed the naugtur-enable-negative-overrides branch from ad9da0a to 8ef7539 Compare June 15, 2022 11:54
@kumavis
Copy link
Member

kumavis commented Jun 16, 2022

nice

@kumavis kumavis merged commit 8315a98 into main Jun 16, 2022
@kumavis kumavis deleted the naugtur-enable-negative-overrides branch June 16, 2022 18:55
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumavis kumavis kumavis approved these changes

@weizman weizman weizman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naugtur @kumavis @weizman