New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browserify/test): result output references in error handling #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
overhead, tests, dev env, etc.
pkg:lavamoat-browserify
Changes in package lavamoat-browserify
labels
Jan 26, 2024
legobeat
added
bug
Something isn't working
chore
overhead, tests, dev env, etc.
and removed
chore
overhead, tests, dev env, etc.
labels
Jan 26, 2024
legobeat
force-pushed
the
fix-test-error-handling
branch
from
January 29, 2024 22:08
003128f
to
f6bef2f
Compare
legobeat
force-pushed
the
fix-test-error-handling
branch
from
January 30, 2024 12:00
f6bef2f
to
be265a7
Compare
legobeat
force-pushed
the
fix-test-error-handling
branch
from
January 30, 2024 20:39
be265a7
to
514d91e
Compare
IIRC, I disabled the
We should re-enable the rule and then disable it on a file-by-file basis. |
boneskull
added a commit
that referenced
this pull request
Jan 30, 2024
boneskull
approved these changes
Jan 30, 2024
legobeat
pushed a commit
that referenced
this pull request
Feb 6, 2024
boneskull
added a commit
that referenced
this pull request
Mar 8, 2024
boneskull
added a commit
that referenced
this pull request
Mar 8, 2024
boneskull
added a commit
that referenced
this pull request
Mar 11, 2024
boneskull
added a commit
that referenced
this pull request
Mar 12, 2024
boneskull
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
chore
overhead, tests, dev env, etc.
pkg:lavamoat-browserify
Changes in package lavamoat-browserify
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression in error-handling in browserify tests introduced in f4292a0 (#698) where a non-existent
res
is referred in error-handling.Ideally cases like this would be caught by lint.