chore(core): run scenarios in ava context #996
+36
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
from
b162047
to
fe0b74e
Compare
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
from
fe0b74e
to
97888b0
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @boneskull and the rest of your teammates on |
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
4 times, most recently
from
10564d1
to
4a630df
Compare
boneskull
changed the base branch from
main
to
boneskull/zap-aa-macos-perf-test
This was referenced Mar 19, 2024
boneskull
force-pushed
the
boneskull/zap-aa-macos-perf-test
branch
from
166c953
to
8fcab2f
Compare
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
from
4a630df
to
220df6a
Compare
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
4 times, most recently
from
57c36e5
to
9408aa2
Compare
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
from
9408aa2
to
c924dc3
Compare
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
2 times, most recently
from
58360bf
to
1202208
Compare
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
from
1202208
to
ac6807f
Compare
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
2 times, most recently
from
ee6922e
to
904dfc6
Compare
naugtur
reviewed
May 23, 2024
| import { loadScenarios } from './scenarios/index.js' | ||
| import Util from './util.js' | ||
|
|
||
| // TODO: figure out why TS does not like the named exports from util.js |
naugtur
reviewed
May 23, 2024
| @@ -0,0 +1,26 @@ | |||
| // @ts-check | |||
|
|
|||
| import test from 'ava' | |||
There was a problem hiding this comment.
Why was the switch to esm necessary?
If only for top-level await, then we can wrap it in an async function and stay within cjs
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
from
904dfc6
to
c56a754
Compare
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
2 times, most recently
from
528ffcf
to
23e0b01
Compare
This changes the `runScenarios` test so that there's a 1:1 mapping between each scenario and an Ava test. This requires changing the file to be `.mjs`, however. Also: ESLint is mightily confused, and after hammering on it for a little bit, I still couldn't figure out what magic incantations I needed to get it to parse the file. Take it or leave it!
boneskull
force-pushed
the
boneskull/core-scenario-test-update
branch
from
23e0b01
to
e0354cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
runScenariostest so that there's a 1:1 mapping between each scenario and an Ava test.This requires changing the file to be
.mjs, however.Also: ESLint is mightily confused, and after hammering on it for a little bit, I still couldn't figure out what magic incantations I needed to get it to parse the file.
Take it or leave it! (by that I mean: I totally understand if nobody wants to merge this. I'm not sure I do!)