Detect trusted HTMLs more safely #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizman
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix issue #95.
The idea is to find a safer way to tell trusted HTMLs from nodes.
The safest way I could think of is to just overwrite the behaviour of
createHTMLso that when a trusted HTML is created, we store it aside.Then, when trying to figure out if a provided object is not a node but a trusted HTML, we can simply look it up in the stash of trusted HTMLs we keep - that way we don't rely on any properties of the trusted HTML object itself, which makes this safe.
Unless there's a way to clone a trusted HTML instance.........?