New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Blob and URL creation behaviour #105

Merged

weizman merged 1 commit into main from fix-some-issues-with-url-creation-and-blobs

Jun 20, 2023

Member

weizman commented Jun 20, 2023

Continuing #88 where a bug was introduces, here are the essence of the changes:

On Figma I learned that sometimes websites create blobs with no type ("") so added that as legit blob type
Also there's a new behaviour in Chrome where creating a URL out of a blob where the URL object belongs to a no longer attached realm returns "" instead of a legit blob url, so i fixed that to make sure URL creation is executed against the top main realm
Added a test to make sure blob with no type cannot be used as html to bypass snow


          fix some stuff

weizman merged commit cde5ac2 into main

2 checks passed

weizman deleted the fix-some-issues-with-url-creation-and-blobs branch

June 20, 2023 13:17

weizman mentioned this pull request

Release 2.0.0 #76

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment