Child frames are overlooked inside opened windows #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weizman
changed the title
weizman
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix attempt for #83
Cool bug.
Function
findWinis being called ontopto find the window we're looking for by recursively going down to all child realms of top. However, opened windows have their owntop, so when they create a new child frame,findWinis called on the originaltopand not the opened windowtop, which naturally makesfindWinto not find the window and therefore gives up on it and not applies protection to it.Fixed by making
findWinwork on all tracked opened windows' tops instead of just the original top.