ruff findings

Makefile

@@ -1,7 +1,7 @@
 check: check-pylint check-black
 
 check-pylint:
-	@poetry run pylint pysolarfocus/*
+	@poetry run pylint --errors-only pysolarfocus/*
 
 check-black:
 	@poetry run black --check pysolarfocus/*
@@ -13,4 +13,7 @@ codefix:
 test:
 	@poetry run pytest
 
-.PHONY: check codefix test
+run: 
+	@poetry run python3 example.py
+
+.PHONY: check codefix test run

example.py

@@ -1,4 +1,4 @@
-from pysolarfocus import SolarfocusAPI, Systems, ApiVersions
+from pysolarfocus import ApiVersions, SolarfocusAPI, Systems
 
 # Create the Solarfocus API client
 solarfocus = SolarfocusAPI(
@@ -17,7 +17,7 @@
 print("\n")
 print(solarfocus.buffers[0])
 print("\n")
-if solarfocus.system is Systems.THERMINATOR:
+if solarfocus.system in  [Systems.THERMINATOR, Systems.ECOTOP]:
     print(solarfocus.biomassboiler)
 if solarfocus.system is Systems.VAMPAIR:
     print(solarfocus.heatpump)

pyproject.toml

@@ -17,20 +17,31 @@ pymodbus = "3.2.2"
 packaging = "^23.1"
 
 [tool.poetry.dev-dependencies]
+ruff = "^0.0.286"
 black = "^22.10.0"
 isort = "^5.10.1"
 pylint = "^2.15.9"
 pytest = "^5.2.0"
 
+
 [build-system]
 requires = ["poetry-core>=1.0.0"]
 build-backend = "poetry.core.masonry.api"
 
 [tool.isort]
 profile = "black"
 
+[tool.ruff]
+# Decrease the maximum line length to 79 characters.
+line-length = 180
+select = [
+  "E",   # pycodestyle
+  "F",   # pyflakes
+  "I",  # pyupgrade
+]
+
 [tool.black]
-target-version = ["py39", "py310"]
+target-version = ["py311"]
 line-length = 180
 
 [tool.pylint.MAIN]

pysolarfocus/__init__.py

@@ -143,15 +143,19 @@ def update_fresh_water_modules(self) -> bool:
 
     def update_heatpump(self) -> bool:
         """Read values from Heating System"""
-        return self.heatpump.update()
+        if self._system is Systems.VAMPAIR:
+            return self.heatpump.update()
+        return True
 
     def update_photovoltaic(self) -> bool:
         """Read values from Heating System"""
         return self.photovoltaic.update()
 
     def update_biomassboiler(self) -> bool:
         """Read values from biomass boiler"""
-        return self.biomassboiler.update()
+        if self._system in [Systems.THERMINATOR, Systems.ECOTOP]:
+            return self.biomassboiler.update()
+        return True
 
     def update_solar(self) -> bool:
         """Read values from Solar"""

pysolarfocus/components/base/data_value.py

@@ -45,7 +45,7 @@ def get_absolute_address(self) -> int:
         Returns the absolute address of the register
         """
         if not self.absolut_address:
-            raise Exception("Absolute address not set!")
+            raise ValueError("Absolute address not set!")
         return self.absolut_address + self.address
 
     @property