Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for ha integration #16

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Improvements for ha integration #16

merged 5 commits into from
Nov 1, 2022

Conversation

LavermanJJ
Copy link
Owner

Changes to support the multiple components PR in HA-integration LavermanJJ/home-assistant-solarfocus#21

  • Allow to initialize with count=0 to avoid this component being updated
  • Adapt naming of entities in various places

@LavermanJJ LavermanJJ self-assigned this Oct 30, 2022
@LavermanJJ LavermanJJ added the enhancement New feature or request label Oct 30, 2022
@LavermanJJ LavermanJJ mentioned this pull request Oct 30, 2022
Merged
7 tasks
@LavermanJJ LavermanJJ marked this pull request as ready for review October 31, 2022 08:52
@LavermanJJ
Copy link
Owner Author

@LLukas22 I've created a testing release with version 0.99.0 and tested this with the HA integration. The only test missing is the config-flow-migration. Apart from this, it looks good.

I'd appreciate a review and your feedback. Thanks in advance!

@LLukas22
Copy link
Contributor

I'll have a look when i get home from work.

LLukas22
LLukas22 reviewed Oct 31, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pysolarfocus/__init__.py Show resolved Hide resolved
pysolarfocus/components/heat_pump.py Outdated Show resolved Hide resolved
pysolarfocus/__init__.py Outdated Show resolved Hide resolved
@LavermanJJ
Copy link
Owner Author

@LLukas22 I've fixed your comments. Do you want to have a second look and approve?

LLukas22
LLukas22 approved these changes Nov 1, 2022
View reviewed changes
pysolarfocus/__init__.py Show resolved Hide resolved
@LLukas22
Copy link
Contributor

LLukas22 commented Nov 1, 2022

LGTM 👍
Maybe think about the versioning but that's probably another task.

@LavermanJJ LavermanJJ merged commit 0b41a7d into main Nov 1, 2022
@LavermanJJ LavermanJJ deleted the improvements_for_ha_integration branch November 1, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LLukas22 LLukas22 LLukas22 approved these changes

Assignees

@LavermanJJ LavermanJJ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LavermanJJ @LLukas22