Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add performance calculations #20

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Add performance calculations #20

merged 2 commits into from
Nov 7, 2022

Conversation

LavermanJJ
Copy link
Owner

@LavermanJJ LavermanJJ commented Nov 7, 2022 •
edited
Loading

Add performance calculations to the heat pump:

  • cop heating
  • cop cooling
  • overall performance
  • overall performance heating
  • overall performance drinking water

I've introduced an abstract class Part to ensure DataValue(Part) and PerformanceCalculator(Part) have the scaled_value property required for the HA-integration.

I've added the calculations to the heat pump component, and did not create a new component, as these calculations belong only to the heat pump and do not affect other components.

@LavermanJJ LavermanJJ self-assigned this Nov 7, 2022
@LavermanJJ LavermanJJ added the enhancement New feature or request label Nov 7, 2022
@LavermanJJ
Copy link
Owner Author

@LLukas22 review, as always, appreciated. 👍

@LavermanJJ LavermanJJ mentioned this pull request Nov 7, 2022
Merged
LLukas22
LLukas22 reviewed Nov 7, 2022
View reviewed changes
pysolarfocus/components/base/component.py Outdated Show resolved Hide resolved
pysolarfocus/components/base/component.py Show resolved Hide resolved
pysolarfocus/components/base/part.py Outdated Show resolved Hide resolved
pysolarfocus/components/base/performance_calculator.py Outdated Show resolved Hide resolved
pysolarfocus/components/heat_pump.py Show resolved Hide resolved
@LavermanJJ LavermanJJ merged commit a72c061 into main Nov 7, 2022
@LavermanJJ LavermanJJ deleted the add-performance-calculations branch November 7, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LLukas22 LLukas22 LLukas22 left review comments

Assignees

@LavermanJJ LavermanJJ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LavermanJJ @LLukas22