Transition to Object Oriented Model + Therminator Unique Register Support #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LavermanJJ
reviewed
Oct 13, 2022
LavermanJJ
reviewed
Oct 13, 2022
LavermanJJ
reviewed
Oct 13, 2022
LavermanJJ
reviewed
Oct 13, 2022
LavermanJJ
reviewed
Oct 13, 2022
LavermanJJ
reviewed
Oct 13, 2022
Co-authored-by: Jeroen Laverman <LavermanJJ@users.noreply.github.com>
Co-authored-by: Jeroen Laverman <LavermanJJ@users.noreply.github.com>
Co-authored-by: Jeroen Laverman <LavermanJJ@users.noreply.github.com>
Co-authored-by: Jeroen Laverman <LavermanJJ@users.noreply.github.com>
LavermanJJ
reviewed
Oct 14, 2022
LavermanJJ
reviewed
Oct 14, 2022
Co-authored-by: Jeroen Laverman <LavermanJJ@users.noreply.github.com>
LavermanJJ
reviewed
Oct 14, 2022
LavermanJJ
reviewed
Oct 14, 2022
|
I did a sanity check with the values (except heating circuit holding), and it looks good 👍 Great work! |
LavermanJJ
reviewed
Oct 14, 2022
LavermanJJ
reviewed
Oct 14, 2022
Co-authored-by: Jeroen Laverman <LavermanJJ@users.noreply.github.com>
|
Alright, 🤞 this should probably work now. |
|
The skipping of registers is not fully working for me. It works for the first gap (between btw. I like the enhanced print 👍 |
|
Yeah, i forgot to offset the count after a gap was already detected. I created a test for this case, should work now. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first draft of the changes to make the api more modular.
All Holding and Input registers were moved into classes abstracting the components of the heating system.
Holdingregisters are now also read as a range instead of single values.
The
init()of the api now accepts a system parameter which defines what and how componenets are initialized.These are a lot of changes, i could only verify the buffer, pelletsboiler and heating_circuit componenets of the Therminator.
I could not test any of the writing api functions. I expect there to be some errors, please test it on your system before merging it.
I also added an example to the readme.