Remove "Show hidden apps" from behavior settings

LawnchairLauncher · Jul 23, 2018 · eb9dc5b · eb9dc5b
1 parent 0434257
commit eb9dc5b
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 18 deletions.
diff --git a/app/src/main/java/ch/deletescape/lawnchair/PreferenceAppFilter.java b/app/src/main/java/ch/deletescape/lawnchair/PreferenceAppFilter.java
@@ -12,6 +12,6 @@ public boolean shouldShowApp(ComponentName app, Context context) {
         if (app.getPackageName().equals(context.getPackageName()))
             return false;
         IPreferenceProvider prefs = Utilities.getPrefs(context);
-        return prefs.getShowHidden() || !Utilities.isAppHidden(context, app.flattenToString());
+        return !Utilities.isAppHidden(context, app.flattenToString());
     }
 }
diff --git a/app/src/main/java/ch/deletescape/lawnchair/preferences/IPreferenceProvider.kt b/app/src/main/java/ch/deletescape/lawnchair/preferences/IPreferenceProvider.kt
@@ -29,8 +29,6 @@ interface IPreferenceProvider {
     // -------------------
 
     val allAppsOpacity: Float
-    // defines if hidden apps should be shown in drawer for changing their hidden state
-    val showHidden: Boolean
     val allAppsIconScale: Float
     val allAppsIconTextScale: Float
     val allAppsIconPaddingScale: Float

diff --git a/app/src/main/java/ch/deletescape/lawnchair/preferences/PreferenceFlags.kt b/app/src/main/java/ch/deletescape/lawnchair/preferences/PreferenceFlags.kt
@@ -35,7 +35,6 @@ object PreferenceFlags {
     const val KEY_BLUR_MODE = "pref_blurMode"
 
     // Boolean
-    const val KEY_SHOW_HIDDEN = "pref_showHidden"
     const val KEY_HOTSEAT_SHOULD_USE_CUSTOM_OPACITY = "pref_hotseatShouldUseCustomOpacity"
     const val KEY_HOTSEAT_SHOULD_USE_EXTRACTED_COLORS = "pref_hotseatShouldUseExtractedColors"
     const val KEY_HOTSEAT_SHOULD_USE_EXTRACTED_COLORS_CACHE = KEY_HOTSEAT_SHOULD_USE_EXTRACTED_COLORS + "_cache"
@@ -67,7 +66,6 @@ object PreferenceFlags {
     const val KEY_SHOW_DATE_OR_WEATHER = "pref_showDateOrWeather"
     const val KEY_SHOW_VOICE_SEARCH_BUTTON = "pref_showMic"
     const val KEY_PREF_ALL_APPS_OPACITY = "pref_allAppsOpacitySB"
-    const val KEY_PREF_SHOW_HIDDEN_APPS = "pref_showHidden"
     const val KEY_PREF_NUM_COLS = "pref_numCols"
     const val KEY_PREF_NUM_COLS_DRAWER = "pref_numColsDrawer"
     const val KEY_PREF_NUM_ROWS = "pref_numRows"

diff --git a/app/src/main/java/ch/deletescape/lawnchair/preferences/PreferenceImpl.kt b/app/src/main/java/ch/deletescape/lawnchair/preferences/PreferenceImpl.kt
@@ -61,7 +61,6 @@ open class PreferenceImpl(context: Context) : IPreferenceProvider {
 
     override val weatherUnit by StringPref(PreferenceFlags.KEY_WEATHER_UNITS, PreferenceFlags.PREF_WEATHER_UNIT_METRIC)
     override val weatherCity by StringPref(PreferenceFlags.KEY_WEATHER_CITY, PreferenceFlags.PREF_WEATHER_DEFAULT_CITY)
-    override val showHidden by BooleanPref(PreferenceFlags.KEY_SHOW_HIDDEN, false)
 
     override fun migrationSrcHotseatCount(default: Int): Int {
         return getInt(PreferenceFlags.KEY_MIGRATION_SRC_HOTSEAT_COUNT, default)

diff --git a/app/src/main/java/ch/deletescape/lawnchair/settings/Settings.java b/app/src/main/java/ch/deletescape/lawnchair/settings/Settings.java
@@ -57,7 +57,6 @@ public void onSharedPreferenceChanged(SharedPreferences prefs, String key) {
                 case PreferenceFlags.KEY_PREF_ALL_APPS_OPACITY:
                     applyAllAppsOpacity(preferences);
                     break;
-                case PreferenceFlags.KEY_PREF_SHOW_HIDDEN_APPS:
                 case PreferenceFlags.KEY_PREF_HIDE_ALL_APPS_APP_LABELS:
                     las.reloadAllApps();
                     break;

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -378,9 +378,6 @@
     <string name="keep_scroll_state_pref_summary">Saves the scroll position in the drawer</string>
     <string name="home_opens_drawer_pref_title">Home button opens app drawer</string>
     <string name="home_opens_drawer_pref_summary">Pressing the home button while on the desktop will open the app drawer</string>
-    <string name="show_hidden_pref_title">Show hidden apps</string>
-    <string name="show_hidden_pref_on">Hidden apps will be shown to change visibility settings</string>
-    <string name="show_hidden_pref_off">Hidden apps won\'t be visible</string>
     <string name="export_db_title">Database</string>
     <string name="import_db_title">Database</string>
     <string name="export_prefs_title">Settings</string>

diff --git a/app/src/main/res/xml/launcher_behavior_preferences.xml b/app/src/main/res/xml/launcher_behavior_preferences.xml
@@ -63,14 +63,6 @@
         android:defaultValue="true"
         android:persistent="true" />
 
-    <SwitchPreference
-        android:key="pref_showHidden"
-        android:title="@string/show_hidden_pref_title"
-        android:summaryOn="@string/show_hidden_pref_on"
-        android:summaryOff="@string/show_hidden_pref_off"
-        android:defaultValue="false"
-        android:persistent="true" />
-
     <SwitchPreference
         android:key="pref_lockDesktop"
         android:title="@string/lock_desktop"