Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deps #2829

Merged
merged 12 commits into from Aug 15, 2022
Merged

Cleanup deps #2829

merged 12 commits into from Aug 15, 2022

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Aug 10, 2022

Description

  • Split versions & Bumping.
  • Add & Remove flags

And you can enable Renovate bot to update deps automatically.

Type of change

✅ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

@yasanglass
Copy link
Member

About Renovate, I'm not sure how different it is from Dependabot but I have used Dependabot and it becomes spammy and annoying very fast.

build.gradle Show resolved Hide resolved
@Goooler
Copy link
Member Author

Goooler commented Aug 10, 2022

About Renovate, I'm not sure how different it is from Dependabot but I have used Dependabot and it becomes spammy and annoying very fast.

  1. Dependabot can't bump Gradle.
  2. Renovate supports version catalogs.

@yasanglass
Copy link
Member

  1. Dependabot can't bump Gradle.
  2. Renovate supports version catalogs.

Idk about version catalogs but I'm not sure what you mean by it cant bump gradle? It bumped everything for me afaik. Anyways, that does not fix the spam issue but we can try I guess.

@Goooler Goooler changed the title Speedup a bit Cleanup deps Aug 10, 2022
@Goooler
Copy link
Member Author

Goooler commented Aug 15, 2022

Fix build after LawnchairLauncher/platform_frameworks_libs_systemui#3 merged.

@Goooler
Copy link
Member Author

Goooler commented Aug 15, 2022

CC @msfjarvis

@msfjarvis msfjarvis merged commit 7f26a4c into LawnchairLauncher:12.1-dev Aug 15, 2022
@Goooler Goooler deleted the speedup branch August 15, 2022 10:37
helliscloser added a commit to helliscloser/vendor_lawnchair that referenced this pull request Aug 19, 2022
Lawnchair Dev update 16/08/22

Changes:
• Workspace: Allow resizing any widget
• Improve stale action configuration
• Cleanup deps (more info here (LawnchairLauncher/lawnchair#2829))
• Add ignore rules (more info here (LawnchairLauncher/lawnchair#2848))
@Goooler Goooler added the dependencies Pull requests that update a dependency file label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants