Introduce Lawnchair Advance Search #3785

MrSluffy · 2023-11-28T02:42:22Z

Screenshot

Description

Initial Implementation advance search in Lawnchair
Enables search functionality across Files, Contacts, Settings Entry, History keyword and Suggestions on the Startpage.

Fixes #3740

Type of change

❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
✅ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

Initial Implementation device search in Lawnchair: Enables search functionality across Files, Contacts, and Suggestions on the Startpage.

lawnchair/src/app/lawnchair/allapps/SearchItemBackground.kt

lawnchair/src/app/lawnchair/allapps/SearchResultIconRow.kt

lawnchair/src/app/lawnchair/allapps/SearchResultText.kt

lawnchair/src/app/lawnchair/search/SearchTargetCompat.kt

lawnchair/src/app/lawnchair/search/SearchTargetUtils.kt

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt

- Use retrofit for fetching suggestions

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt

suphon-t · 2023-11-28T16:11:30Z

Haven’t looked into the code yet, but I think suggestions should be under the search provider that it comes from instead. Having it under device search is a bit misleading because “device search” sounds like a local search.

pacjo · 2023-11-28T18:08:20Z

Shouldn't suggestions be disabled by default, since it's sending data to 3rd party? Also ability to choose search provider would be nice.

Otherwise everything's working fine, albeit a bit slower then with only app search.

heckarman · 2023-11-28T19:17:25Z

Can this be a replacement for Pixel Search app?

MrSluffy · 2023-11-28T23:50:59Z

Haven’t looked into the code yet, but I think suggestions should be under the search provider that it comes from instead. Having it under device search is a bit misleading because “device search” sounds like a local search.

Right, that make sense, let's add new category as Search provider / Suggestion provider in app drawer since it doesn't make sense to put it in dock since most of the dock func is redirect to browser / apps.

lawnchair/src/app/lawnchair/allapps/SearchResultRightLeftIcon.kt

lawnchair/src/app/lawnchair/allapps/SearchResultText.kt

lawnchair/src/app/lawnchair/allapps/SearchResultView.kt

lawnchair/src/app/lawnchair/search/LawnchairSearchAlgorithm.kt

lawnchair/src/app/lawnchair/search/SearchTargetUtils.kt

lawnchair/src/app/lawnchair/search/data/SearchDataInfo.kt

MrSluffy · 2023-11-29T05:05:29Z

https://i.imgur.com/d9evRkx.png after spotlessApply https://i.imgur.com/IDvJeS1.png please revert it @Goooler

Goooler · 2023-11-29T05:09:29Z

Ooops, mis-read them.

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt

SuperDragonXD

Just a few string changes.

Regarding "suggestions", I've also clarified that the suggestions come from the web (startpage).

I'm gonna suggest more changes related to the UI in both preferences and the actual search interface later.

lawnchair/res/values/strings.xml

lawnchair/src/app/lawnchair/ui/preferences/AppDrawerPreferences.kt

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt

suphon-t · 2023-11-29T08:26:42Z

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt

+
+val startPageService: StartPageService = retrofit.create(StartPageService::class.java)
+
+suspend fun getStartPageSuggestions(query: String, max: Int): List<String> {


Still think that this should be tied to the user's current search provider.
For example, a user that selected startpage as the provider should get suggestions from startpage, or a user that selected duckduckgo should get suggestions from duckduckgo.

I see, but we don't have endpoint for other provider, we only have from startpage. and also the current dock search implementation doesnt support your suggestions. it just redirect to browser when click.

We could make tapping the dock open the drawer search instead. That way the user could type instantly without waiting for the browser to load.

About the other providers, what happens if the user clicks a startpage suggestion while using another provider?

Yes we can do that.

nothing, since it's not tied in the search provider in dock. I guess we can update it later on when we tied dock search bar to all appsearch

lawnchair/src/app/lawnchair/search/GenerateSearchTarget.kt

Goooler · 2023-12-06T14:54:52Z

lawnchair/src/app/lawnchair/search/GenerateSearchTarget.kt

+        val fileUri = when (info) {
+            is FileInfo -> Uri.withAppendedPath(
+                MediaStore.Files.getContentUri("external"),
+                info.fileId,


Why don't use file path to generate uri?

It doesn't open the file as it's intended, it just redirected/open the selected app

val intent = Intent(Intent.ACTION_VIEW) .addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) .addFlags(Intent.FLAG_GRANT_WRITE_URI_PERMISSION) .setDataAndType(path.path2Uri(), mime.mimeCompat) context?.startActivity(intent)

This should work, I just tried it on my file manager.

Probably cause I grant it with ACTION_MANAGE_APP_ALL_FILES_ACCESS_PERMISSION?

Adding startActivity is useless here as it's already exists in SearchResultView

And it doesn't open the png/MP4 etc in respected app like Photos/gallery

Wired, it opens mp4 in my video player, and opens png in my photo viewer.

Wired, it opens mp4 in my video player, and opens png in my photo viewer.

I'm pretty sure it doesn't, I tested in several apps and android 10 to 14 using emulator

Alright, will investigate it when I'm free of time.

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt

Goooler · 2023-12-06T15:05:19Z

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt

+
+            if (response.isSuccessful) {
+                val responseBody = response.body()?.string()
+                val suggestions = JSONArray(responseBody).optJSONArray(1)?.let { array ->


May KotlinX Json API instead.

it doesn't need to since the response is something like this
["popcorn",["popcorn", "popcorn instrumental", "popcorn sutton", "popcornflix" ]] and the current is very straight forward and it's works as intended

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt

- As we don't how long gonna take to receive response in startpage

SuperDragonXD

I have some minor string suggestions.

Also, the current Preferences UI seems to be very convoluted and not-user friendly at all. I'll make a PR to fix this once this PR is merged.

SuperDragonXD · 2023-12-08T12:57:05Z

lawnchair/res/values/strings.xml

+    <string name="perform_wide_search_file">Files</string>
+    <string name="pref_suggestion_title">Web suggestions (via <xliff:g id="startpage">Startpage</xliff:g>)</string>
+    <string name="pref_advance_search_category">Advanced Search</string>
+    <string name="perform_wide_search_description">Search your contacts and files in app drawer search. Enable in App Drawer settings.</string>


Actually, removing the last line should be fine.

Suggested change

<string name="perform_wide_search_description">Search your contacts and files in app drawer search. Enable in App Drawer settings.</string>

<string name="perform_wide_search_description">Search your contacts, files, and settings in app drawer search.</string>

SuperDragonXD · 2023-12-08T12:57:59Z

lawnchair/res/values/strings.xml

+    <string name="warn_contact_permission_content">Requires contact permission</string>
+    <string name="warn_files_permission_content">Requires storage permission</string>
+
+    <string name="all_apps_search_result_files_description">Show files in search result</string>


Suggested change

<string name="all_apps_search_result_files_description">Show files in search result</string>

<string name="all_apps_search_result_files_description">Media, documents, folders, and more.</string>

SuperDragonXD · 2023-12-08T12:58:39Z

lawnchair/res/values/strings.xml

+    <string name="warn_files_permission_content">Requires storage permission</string>
+
+    <string name="all_apps_search_result_files_description">Show files in search result</string>
+    <string name="all_apps_search_result_contacts_description">Show contacts in search result</string>


Suggested change

<string name="all_apps_search_result_contacts_description">Show contacts in search result</string>

<string name="all_apps_search_result_contacts_description">Contacts and more</string>

Goooler · 2023-12-09T08:56:35Z

lawnchair/src/app/lawnchair/search/GenerateSearchTarget.kt

+    internal fun getStartPageSearchItem(query: String): SearchTargetCompat {
+        val url = getStartPageUrl(query)
+        val id = "browser:$query"
+        val browserIntent = Intent(Intent.ACTION_VIEW, Uri.parse(url))
+        val action = SearchActionCompat.Builder(id, context.getString(R.string.all_apps_search_startpage_message))
+            .setIcon(Icon.createWithResource(context, R.drawable.ic_startpage))
+            .setIntent(browserIntent)
+            .build()
+        val extras = bundleOf(
+            SearchResultView.EXTRA_HIDE_SUBTITLE to true,
+        )
+        return createSearchTarget(id, action, START_PAGE, extras)
+    }


Search item is always showing in the results, even if after turning Web suggestions off, is this an intended behavior?

No it doesn't show in my end, and this is not related to showing or showing of web suggestion, this only for wrapping the search result item , please check : https://github.com/LawnchairLauncher/lawnchair/blob/13-dev/lawnchair/src/app/lawnchair/search/LawnchairSearchAlgorithm.kt#L213

https://github.com/LawnchairLauncher/lawnchair/blob/13-dev/lawnchair/src/app/lawnchair/search/LawnchairSearchAlgorithm.kt#L191

maybe you got confused, there's a web suggestion and recent suggestion : https://github.com/LawnchairLauncher/lawnchair/blob/13-dev/lawnchair/src/app/lawnchair/search/LawnchairSearchAlgorithm.kt#L226

No, that is not web suggestion

and we don't have option for that

and we don't have option for that

Is this intended?

This one is web suggestion

and we don't have option for that

Is this intended?

Yes but if you want to add option you can do it here : https://github.com/LawnchairLauncher/lawnchair/blob/13-dev/lawnchair/src/app/lawnchair/search/LawnchairAppSearchAlgorithm.kt#L149

@gooler

* Introduce Lawnchair Device Search Initial Implementation device search in Lawnchair: Enables search functionality across Files, Contacts, and Suggestions on the Startpage. * Apply reviewed suggestions by @gooler - Use retrofit for fetching suggestions * use kotlinxJson * Separate suggestion * Apply changes code refine @Goooler * Fix styling * Implement MIME Type Compat * Apply suggestion changes by @suphon-t * Apply suggestion changes by @SuperDragonXD * Cleanup * Remodel FileInfo * Private retrofit * Clean up SearchRequest * Add FileExtensions * Optimize file search method * Fix style * Rename * Optimize file opening * Add type checkers * Reformat AVDs * Fixed crash java.lang.ClassCastException error logs : https://katb.in/abahivihaqu * More fixes * Surround try catch to give proper error logs java.lang.NullPointerException at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invokeSuspend(SearchRequest.kt:124) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:8) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:4) at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:78) at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(Builders.common.kt:167) at kotlinx.coroutines.BuildersKt.withContext(Unknown Source:1) at app.lawnchair.search.data.SearchRequestKt.findContactsByName(SearchRequest.kt:68) at app.lawnchair.search.LawnchairSearchAlgorithm$performDeviceWideSearch$2.invokeSuspend(LawnchairSearchAlgorithm.kt:152) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) * Fixed opened file instead of just redirect to file manager * Fixed crash opening folder * Initial implementation callback * Add max results option for files, suggestion and people * Add initial settings entry * Properly use folder mimetype * Fixed target icon styling * Cleanups * Revert * Fixes * Apply suggestions by @Goooler * Fixed crash on external storage directory * Implement history keyword using built-in SearchRecentSuggestionsProvider * misc fixes * Add timeout 3 seconds - As we don't how long gonna take to receive response in startpage * Misc fixes * Misc fixes --------- Co-authored-by: Goooler <wangzongler@gmail.com>

@gooler

* Introduce Lawnchair Device Search Initial Implementation device search in Lawnchair: Enables search functionality across Files, Contacts, and Suggestions on the Startpage. * Apply reviewed suggestions by @gooler - Use retrofit for fetching suggestions * use kotlinxJson * Separate suggestion * Apply changes code refine @Goooler * Fix styling * Implement MIME Type Compat * Apply suggestion changes by @suphon-t * Apply suggestion changes by @SuperDragonXD * Cleanup * Remodel FileInfo * Private retrofit * Clean up SearchRequest * Add FileExtensions * Optimize file search method * Fix style * Rename * Optimize file opening * Add type checkers * Reformat AVDs * Fixed crash java.lang.ClassCastException error logs : https://katb.in/abahivihaqu * More fixes * Surround try catch to give proper error logs java.lang.NullPointerException at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invokeSuspend(SearchRequest.kt:124) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:8) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:4) at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:78) at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(Builders.common.kt:167) at kotlinx.coroutines.BuildersKt.withContext(Unknown Source:1) at app.lawnchair.search.data.SearchRequestKt.findContactsByName(SearchRequest.kt:68) at app.lawnchair.search.LawnchairSearchAlgorithm$performDeviceWideSearch$2.invokeSuspend(LawnchairSearchAlgorithm.kt:152) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) * Fixed opened file instead of just redirect to file manager * Fixed crash opening folder * Initial implementation callback * Add max results option for files, suggestion and people * Add initial settings entry * Properly use folder mimetype * Fixed target icon styling * Cleanups * Revert * Fixes * Apply suggestions by @Goooler * Fixed crash on external storage directory * Implement history keyword using built-in SearchRecentSuggestionsProvider * misc fixes * Add timeout 3 seconds - As we don't how long gonna take to receive response in startpage * Misc fixes * Misc fixes --------- Co-authored-by: Goooler <wangzongler@gmail.com>

@gooler

* Introduce Lawnchair Device Search Initial Implementation device search in Lawnchair: Enables search functionality across Files, Contacts, and Suggestions on the Startpage. * Apply reviewed suggestions by @gooler - Use retrofit for fetching suggestions * use kotlinxJson * Separate suggestion * Apply changes code refine @Goooler * Fix styling * Implement MIME Type Compat * Apply suggestion changes by @suphon-t * Apply suggestion changes by @SuperDragonXD * Cleanup * Remodel FileInfo * Private retrofit * Clean up SearchRequest * Add FileExtensions * Optimize file search method * Fix style * Rename * Optimize file opening * Add type checkers * Reformat AVDs * Fixed crash java.lang.ClassCastException error logs : https://katb.in/abahivihaqu * More fixes * Surround try catch to give proper error logs java.lang.NullPointerException at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invokeSuspend(SearchRequest.kt:124) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:8) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:4) at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:78) at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(Builders.common.kt:167) at kotlinx.coroutines.BuildersKt.withContext(Unknown Source:1) at app.lawnchair.search.data.SearchRequestKt.findContactsByName(SearchRequest.kt:68) at app.lawnchair.search.LawnchairSearchAlgorithm$performDeviceWideSearch$2.invokeSuspend(LawnchairSearchAlgorithm.kt:152) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) * Fixed opened file instead of just redirect to file manager * Fixed crash opening folder * Initial implementation callback * Add max results option for files, suggestion and people * Add initial settings entry * Properly use folder mimetype * Fixed target icon styling * Cleanups * Revert * Fixes * Apply suggestions by @Goooler * Fixed crash on external storage directory * Implement history keyword using built-in SearchRecentSuggestionsProvider * misc fixes * Add timeout 3 seconds - As we don't how long gonna take to receive response in startpage * Misc fixes * Misc fixes --------- Co-authored-by: Goooler <wangzongler@gmail.com>

@gooler

* Introduce Lawnchair Device Search Initial Implementation device search in Lawnchair: Enables search functionality across Files, Contacts, and Suggestions on the Startpage. * Apply reviewed suggestions by @gooler - Use retrofit for fetching suggestions * use kotlinxJson * Separate suggestion * Apply changes code refine @Goooler * Fix styling * Implement MIME Type Compat * Apply suggestion changes by @suphon-t * Apply suggestion changes by @SuperDragonXD * Cleanup * Remodel FileInfo * Private retrofit * Clean up SearchRequest * Add FileExtensions * Optimize file search method * Fix style * Rename * Optimize file opening * Add type checkers * Reformat AVDs * Fixed crash java.lang.ClassCastException error logs : https://katb.in/abahivihaqu * More fixes * Surround try catch to give proper error logs java.lang.NullPointerException at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invokeSuspend(SearchRequest.kt:124) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:8) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:4) at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:78) at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(Builders.common.kt:167) at kotlinx.coroutines.BuildersKt.withContext(Unknown Source:1) at app.lawnchair.search.data.SearchRequestKt.findContactsByName(SearchRequest.kt:68) at app.lawnchair.search.LawnchairSearchAlgorithm$performDeviceWideSearch$2.invokeSuspend(LawnchairSearchAlgorithm.kt:152) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) * Fixed opened file instead of just redirect to file manager * Fixed crash opening folder * Initial implementation callback * Add max results option for files, suggestion and people * Add initial settings entry * Properly use folder mimetype * Fixed target icon styling * Cleanups * Revert * Fixes * Apply suggestions by @Goooler * Fixed crash on external storage directory * Implement history keyword using built-in SearchRecentSuggestionsProvider * misc fixes * Add timeout 3 seconds - As we don't how long gonna take to receive response in startpage * Misc fixes * Misc fixes --------- Co-authored-by: Goooler <wangzongler@gmail.com>

@gooler

* Introduce Lawnchair Device Search Initial Implementation device search in Lawnchair: Enables search functionality across Files, Contacts, and Suggestions on the Startpage. * Apply reviewed suggestions by @gooler - Use retrofit for fetching suggestions * use kotlinxJson * Separate suggestion * Apply changes code refine @Goooler * Fix styling * Implement MIME Type Compat * Apply suggestion changes by @suphon-t * Apply suggestion changes by @SuperDragonXD * Cleanup * Remodel FileInfo * Private retrofit * Clean up SearchRequest * Add FileExtensions * Optimize file search method * Fix style * Rename * Optimize file opening * Add type checkers * Reformat AVDs * Fixed crash java.lang.ClassCastException error logs : https://katb.in/abahivihaqu * More fixes * Surround try catch to give proper error logs java.lang.NullPointerException at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invokeSuspend(SearchRequest.kt:124) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:8) at app.lawnchair.search.data.SearchRequestKt$findContactsByName$2.invoke(Unknown Source:4) at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:78) at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(Builders.common.kt:167) at kotlinx.coroutines.BuildersKt.withContext(Unknown Source:1) at app.lawnchair.search.data.SearchRequestKt.findContactsByName(SearchRequest.kt:68) at app.lawnchair.search.LawnchairSearchAlgorithm$performDeviceWideSearch$2.invokeSuspend(LawnchairSearchAlgorithm.kt:152) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) * Fixed opened file instead of just redirect to file manager * Fixed crash opening folder * Initial implementation callback * Add max results option for files, suggestion and people * Add initial settings entry * Properly use folder mimetype * Fixed target icon styling * Cleanups * Revert * Fixes * Apply suggestions by @Goooler * Fixed crash on external storage directory * Implement history keyword using built-in SearchRecentSuggestionsProvider * misc fixes * Add timeout 3 seconds - As we don't how long gonna take to receive response in startpage * Misc fixes * Misc fixes --------- Co-authored-by: Goooler <wangzongler@gmail.com>

Introduce Lawnchair Device Search

db0e639

Initial Implementation device search in Lawnchair: Enables search functionality across Files, Contacts, and Suggestions on the Startpage.

MrSluffy requested review from suphon-t, Goooler, yasanglass and SuperDragonXD November 28, 2023 02:42

MrSluffy linked an issue Nov 28, 2023 that may be closed by this pull request

[BUG] App search is broken on 13-dev #3740

Closed

Goooler reviewed Nov 28, 2023

View reviewed changes

MrSluffy added the feature label Nov 28, 2023

Apply reviewed suggestions by @gooler

919b8f1

- Use retrofit for fetching suggestions

Goooler reviewed Nov 28, 2023

View reviewed changes

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt Outdated Show resolved Hide resolved

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt Outdated Show resolved Hide resolved

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt Outdated Show resolved Hide resolved

use kotlinxJson

ec25a57

Separate suggestion

eb7cec7

MrSluffy changed the title ~~Introduce Lawnchair Device Search~~ Introduce Lawnchair Advance Search Nov 29, 2023

Merge branch '13-dev' into wide-search

7fe26cf

Goooler reviewed Nov 29, 2023

View reviewed changes

MrSluffy added 2 commits November 29, 2023 12:49

Apply changes code refine @Goooler

329e8f7

Fix styling

70cb409

Goooler mentioned this pull request Nov 29, 2023

Add complete mime types mapping #3790

Merged

Goooler force-pushed the wide-search branch from 544c4f3 to 70cb409 Compare November 29, 2023 05:09

MrSluffy added 2 commits November 29, 2023 13:21

Merge branch '13-dev' into wide-search

eb3edbc

Implement MIME Type Compat

9479da9

Goooler reviewed Nov 29, 2023

View reviewed changes

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt Outdated Show resolved Hide resolved

SuperDragonXD reviewed Nov 29, 2023

View reviewed changes

suphon-t reviewed Nov 29, 2023

View reviewed changes

MrSluffy added 3 commits December 6, 2023 21:14

Add initial settings entry

9876b0d

Merge branch '13-dev' into wide-search

ec9a8cf

Properly use folder mimetype

4f009a0

MrSluffy marked this pull request as ready for review December 6, 2023 13:44

MrSluffy and others added 2 commits December 6, 2023 22:22

Fixed target icon styling

e233c87

Cleanups

f404430

Goooler reviewed Dec 6, 2023

View reviewed changes

MrSluffy commented Dec 6, 2023

View reviewed changes

lawnchair/src/app/lawnchair/search/data/SearchRequest.kt Outdated Show resolved Hide resolved

Goooler and others added 8 commits December 6, 2023 23:41

Revert

3616680

Fixes

0c1483f

Apply suggestions by @Goooler

d3a0065

Fixed crash on external storage directory

370e414

Implement history keyword using built-in SearchRecentSuggestionsProvider

bad99a6

misc fixes

a047fa8

Add timeout 3 seconds

c61d395

- As we don't how long gonna take to receive response in startpage

Misc fixes

368c935

SuperDragonXD reviewed Dec 8, 2023

View reviewed changes

MrSluffy added 2 commits December 9, 2023 07:58

Misc fixes

5b33f1d

Merge branch '13-dev' into wide-search

b401bd0

MrSluffy merged commit be8bb75 into 13-dev Dec 9, 2023
4 checks passed

MrSluffy deleted the wide-search branch December 9, 2023 00:13

Goooler reviewed Dec 9, 2023

View reviewed changes

pacjo mentioned this pull request Dec 14, 2023

[BUG] Apps in app drawer search prompt to open the Play Store if icon isn't clicked #3854

Closed

pacjo mentioned this pull request Dec 17, 2023

[BUG] Blurry recent #2762

Closed

MrSluffy mentioned this pull request Dec 19, 2023

[FEATURE] Add Custom Search Bar with an App #3890

Closed


		val startPageService: StartPageService = retrofit.create(StartPageService::class.java)

		suspend fun getStartPageSuggestions(query: String, max: Int): List<String> {

	<string name="perform_wide_search_description">Search your contacts and files in app drawer search. Enable in App Drawer settings.</string>
	<string name="perform_wide_search_description">Search your contacts, files, and settings in app drawer search.</string>

	<string name="all_apps_search_result_files_description">Show files in search result</string>
	<string name="all_apps_search_result_files_description">Media, documents, folders, and more.</string>

	<string name="all_apps_search_result_contacts_description">Show contacts in search result</string>
	<string name="all_apps_search_result_contacts_description">Contacts and more</string>

Introduce Lawnchair Advance Search #3785

Introduce Lawnchair Advance Search #3785

Conversation

MrSluffy commented Nov 28, 2023 • edited

Description

Type of change

suphon-t commented Nov 28, 2023

pacjo commented Nov 28, 2023

heckarman commented Nov 28, 2023

MrSluffy commented Nov 28, 2023

MrSluffy commented Nov 29, 2023

Goooler commented Nov 29, 2023

SuperDragonXD left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrSluffy Dec 6, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrSluffy Dec 7, 2023 • edited

Choose a reason for hiding this comment

SuperDragonXD left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrSluffy Dec 9, 2023 • edited

Choose a reason for hiding this comment

MrSluffy commented Nov 28, 2023 •

edited

MrSluffy Dec 6, 2023 •

edited

MrSluffy Dec 7, 2023 •

edited

SuperDragonXD left a comment •

edited

MrSluffy Dec 9, 2023 •

edited