Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libember can segfault or abort when receiving random erroneous bytes #103

Closed
benoitquiniou opened this issue Nov 14, 2019 · 1 comment
Closed

libember can segfault or abort when receiving random erroneous bytes #103

benoitquiniou opened this issue Nov 14, 2019 · 1 comment
Assignees
@benoitquiniou
Labels
Component-LibEmber Kind-Bug

Comments

@benoitquiniou
Copy link
Contributor

Receiving some random erroneous bytes can segfault or abort the decoding side.
The location is in libember::dom::AsyncDomReader::containerReady, where decodeNode return value is not checked againts null pointer before use.
@benoitquiniou benoitquiniou self-assigned this Nov 14, 2019
benoitquiniou added a commit that referenced this issue Nov 14, 2019
@benoitquiniou
Make decoder more robust to random erroneous bytes. Fixes issue #103
0659f96
@benoitquiniou
Copy link
Contributor Author

Fixed by commit 0659f96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitquiniou benoitquiniou

Labels
Component-LibEmber Kind-Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benoitquiniou