Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

portal: do not pause between event bus ticks, only $apply when needed #27

Closed
x1B opened this issue Jul 3, 2014 · 1 comment
Closed

portal: do not pause between event bus ticks, only $apply when needed #27

x1B opened this issue Jul 3, 2014 · 1 comment
Labels
epic: runtime type: enhancement

Comments

@x1B
Copy link
Member

x1B commented Jul 3, 2014

Currently, the portal uses $timeout as the nextTick implementation for the event bus. This causes a full AngularJS digest-cycle after each tick, and also lets (most) browsers think that they should do a repaint.

Instead, all ticks should occur directly in a row, followed by a $digest cycle. If new events were produces during the cycle, the process repeats.
@x1B x1B added the enhancement label Jul 3, 2014
x1B added a commit that referenced this issue Jul 3, 2014
@x1B
(#27) do not pause for ticks
3ba7ff5
x1B added a commit that referenced this issue Jul 3, 2014
@x1B
(#27) do not pause for ticks
29d035a
x1B added a commit that referenced this issue Jul 3, 2014
@x1B
(#27) Changelog
b011743
x1B added a commit that referenced this issue Jul 3, 2014
@x1B
Merge branch 'feature/27-no-pause-between-event-bus-ticks-rebase'
8e40b3a 
* feature/27-no-pause-between-event-bus-ticks-rebase:
  (#27) Changelog
  (#27) do not pause for ticks
@x1B
Copy link
Member Author

x1B commented Jul 3, 2014

Implemented on master, expected for v0.10.0

@x1B x1B closed this as completed Jul 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
epic: runtime type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@x1B @alex3683