Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved parser for TLD .it #84

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Conversation

frauri
Copy link
Contributor

@frauri frauri commented Jan 13, 2023

Q A
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Added handler for TLD .it to correctly parse name servers and organization name/registrar name which in the current version are merged into a single "Organization" line

Old parser

"Name Server":[],
"Organization":"Google Ireland Holdings Unlimited Company Google LLC Google LLC MarkMonitor International Limited",
"Registrar": "line missing"

New parser

"Name Server":["ns1.google.com","ns2.google.com","ns3.google.com","ns4.google.com"],
"Organization":"Google Ireland Holdings Unlimited Company Google LLC Google LLC",
"Registrar":"MarkMonitor International Limited MARKMONITOR-REG"

@height
Copy link

height bot commented Jan 13, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@AndreiIgna
Copy link
Member

hey @frauri thanks for adding support for .it, this is a useful one

@AndreiIgna AndreiIgna merged commit 8a35b77 into LayeredStudio:master Jan 13, 2023
@AndreiIgna
Copy link
Member

AndreiIgna commented Jan 14, 2023

.it infos are better https://dmns.app/google.it/history but I think we can still improve it further 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants