Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves .it parsing to preserve date structure and more. #92

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

jonathansampson
Copy link
Contributor

@jonathansampson jonathansampson commented Feb 1, 2023

Q A
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #91 and #44
License MIT

Original Result:

{
  "whois.nic.it": {
    "Domain Status": [ "ok" ],
    "Name Server": [
      "ns1.google.com",
      "ns2.google.com",
      "ns3.google.com",
      "ns4.google.com"
    ],
    "Domain Name": "google.it",
    "Signed": "no",
    "Created Date": "1999-12-10 00:00:00 2018-03-02 19:04:02 2022-05-18 21:12:35 2017-12-21 19:54:04",
    "Updated Date": "2022-05-18 21:29:19 2018-03-02 19:04:02 2022-05-18 21:12:35 2017-12-21 19:54:04",
    "Expiry Date": "2023-04-21",
    "Organization": "Google Ireland Holdings Unlimited Company Google LLC Google LLC",
    "Address": "70 Sir John Rogerson's Quay 1600 Amphitheatre Parkway 1600 Amphitheatre Parkway",
    "Name": "Rajiv Prasad Domain Administrator",
    "Registrar": "MarkMonitor International Limited MARKMONITOR-REG",
    "Registrar Web": "https://www.markmonitor.com/",
    "Registrar DNSSEC": "no",
    "text": [
      "*********************************************************************",
      "* Please note that the following result could be a subgroup of      *",
      "* the data contained in the database.                               *",
      "*                                                                   *",
      "* Additional information can be visualized at:                      *",
      "* http://web-whois.nic.it                                           *",
      "*********************************************************************",
      "Registrant",
      "Dublin",
      "2",
      "Dublin",
      "IE",
      "",
      "Admin Contact",
      "Mountain View",
      "94043",
      "CA",
      "US",
      "",
      "Technical Contacts",
      "Mountain View",
      "94043",
      "CA",
      "US"
    ]
  }
}

Updated Result:

{
  "whois.nic.it": {
    "Domain Status": [ "ok" ],
    "Name Server": [
      "ns1.google.com",
      "ns2.google.com",
      "ns3.google.com",
      "ns4.google.com"
    ],
    "Domain Name": "google.it",
    "Signed": "no",
    "Created Date": "1999-12-10 00:00:00",
    "Updated Date": "2022-05-18 21:29:19",
    "Expiry Date": "2023-04-21",
    "Registrant Organization": "Google Ireland Holdings Unlimited Company",
    "Registrant Address": "70 Sir John Rogerson's Quay, Dublin, 2, Dublin, IE",
    "Registrant Created": "2018-03-02 19:04:02",
    "Registrant Last Update": "2018-03-02 19:04:02",
    "Admin Contact Name": "Rajiv Prasad",
    "Admin Contact Organization": "Google LLC",
    "Admin Contact Address": "1600 Amphitheatre Parkway, Mountain View, 94043, CA, US",     
    "Admin Contact Created": "2022-05-18 21:12:35",
    "Admin Contact Last Update": "2022-05-18 21:12:35",
    "Technical Contacts Name": "Domain Administrator",
    "Technical Contacts Organization": "Google LLC",
    "Technical Contacts Address": "1600 Amphitheatre Parkway, Mountain View, 94043, CA, US",
    "Technical Contacts Created": "2017-12-21 19:54:04",
    "Technical Contacts Last Update": "2017-12-21 19:54:04",
    "Registrar": "MarkMonitor International Limited MARKMONITOR-REG",
    "Registrar Web": "https://www.markmonitor.com/",
    "Registrar DNSSEC": "no",
    "text": [ "" ]
  }
}

@height
Copy link

height bot commented Feb 1, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@AndreiIgna AndreiIgna merged commit f7df16b into LayeredStudio:master Feb 4, 2023
@AndreiIgna
Copy link
Member

thanks @jonathansampson, the data for .it much better and this is now included in the v1.15 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Dates for .it TLDs
2 participants