Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataapi] GRPC Dial with timeout #462

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

siddimore
Copy link
Contributor

Why are these changes needed?

Add a timeout in creating GRPC connections.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore requested review from dmanc and jianoaix April 9, 2024 15:17
@siddimore siddimore merged commit 9a09336 into Layr-Labs:master Apr 10, 2024
6 checks passed
bxue-l2 pushed a commit to bxue-l2/eigenda that referenced this pull request Apr 11, 2024
Co-authored-by: Siddharth More <Siddhi More>
bxue-l2 pushed a commit to bxue-l2/eigenda that referenced this pull request Apr 11, 2024
Co-authored-by: Siddharth More <Siddhi More>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants