Add retry for graph node #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
reviewed
Apr 11, 2024
ian-shim
reviewed
Apr 12, 2024
| } | ||
| retryCount++ | ||
|
|
||
| err := q.GraphQLQuerier.Query(ctx, query, variables) |
There was a problem hiding this comment.
Maybe in a future PR, but it should check err and only retry on transient errors (429/5xx). If the request itself is invalid, retries shouldn't be made.
There was a problem hiding this comment.
I'm not really sure how to tell in this case. Going to leave this for a future PR.
bxue-l2
approved these changes
Apr 12, 2024
jianoaix
approved these changes
Apr 12, 2024
| return args.Error(0) | ||
| } | ||
|
|
||
| func TestRetryQuerier_Query(t *testing.T) { |
There was a problem hiding this comment.
Is it conventional to use underscore in golang naming?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks