Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed type double issue #53

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Fixed type double issue #53

merged 3 commits into from
Aug 12, 2019

Conversation

anant-svc
Copy link
Collaborator

@anant-svc anant-svc commented Mar 29, 2019 •
edited
Loading

Issue: #47 - Fixed double issue if the gettype($variable) returns integer for non-decimal number

@ewistrand
Copy link

+1

Greg0
Greg0 requested changes Aug 12, 2019
View reviewed changes
Copy link
Collaborator

@Greg0 Greg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think current unit tests should pass without changes in them. Are they really invalid or just not passing after changes?

@anant-svc anant-svc merged commit 8eab07f into master Aug 12, 2019
@anant-svc
Copy link
Collaborator Author

Just for the sake of the changes I have made a unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Greg0 Greg0 Greg0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anant-svc @ewistrand @Greg0