Skip to content

Commit

Permalink
p.row is now deprecated.
Browse files Browse the repository at this point in the history
  • Loading branch information
Lazerbeak12345 committed Feb 5, 2022
1 parent f7b5778 commit 738b578
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 16 deletions.
13 changes: 9 additions & 4 deletions README.md
Expand Up @@ -83,7 +83,7 @@ The example code above included `B2/S23` (AKA "Conway's game of Life") as an exa

## Documentation

Function-by funciton documentation. (Updated last on version `3.2.0`)
Function-by funciton documentation. (Updated last on version `3.3.0`)

### The global

Expand Down Expand Up @@ -517,12 +517,17 @@ The coordinates of where the center of the zoomelm is windowed at.

#### row

The row that elements such as `Rule 90` are getting proccessed at.
The row that elements such as `Rule 90` used to get proccessed at.

For backward compatibility this has been kept (for this version), and still
functions the same, though wolfram rules no longer require it.


[bug23]: https://github.com/Lazerbeak12345/pixelmanipulator/issues/23

> This is actually a symptom of [a bug][bug23]. A later major version release will have
> the goal of removing this, and the associated bug.
> This was actually a symptom of [a bug][bug23]. A later major version release will have the goal of removing `p.row` entirely as it is now **DEPRECATED**
> The demo no longer indicates what row is in-use.
#### elementTypeMap

Expand Down
11 changes: 1 addition & 10 deletions pixelmanipulator.html
Expand Up @@ -66,12 +66,6 @@
#selectorBox:hover{
border:solid rgba(255,255,255,.5) 1px;
}
#workingLine{/*This is the line that says where the elements such as the wolfram elemnts are currently being rendered*/
width:4px;
height:1px;
background:red;
position:absolute;
}
input[type="text"]{
text-align:right;
width:3em;
Expand All @@ -90,7 +84,6 @@
<div id="smallxline" style="width:1px; height:100%; top:0px;"></div>
<div id="smallyline" style="height:1px; width:100%; left:0px;"></div>
<div id="selectorBox"></div>
<div id="workingLine"></div>
<div id="zoom-box"><!--This is the container for the zoomed-in box that the user can interact with-->
<canvas id="zoom" width="400" height="400"></canvas><!--This is the zoomed-in box that the user can interact with-->
<div id="actions-box">
Expand Down Expand Up @@ -148,7 +141,7 @@
<a target="_blank" href="https://github.com/Lazerbeak12345/pixelmanipulator">View Pixelmanipulator On GitHub!</a>
</div>
<!-- Frontend will be 2.0.0 when I refresh the GUI's look. -->
Library v<span id="backendversion"></span>, Frontend v1.28.0
Library v<span id="backendversion"></span>, Frontend v1.29.0
</div><!--The frontend version is different because there are changes that don't impact the rest of the library -->
</div>
</div>
Expand Down Expand Up @@ -439,8 +432,6 @@
});
}
p.onIterate=function() {
document.getElementById("workingLine").style.top=p.row+"px";
document.getElementById("workingLine").style.left=(p.get_width()+1)+"px";
if (timedebug) lasttime=performance.now();
frames++;
}
Expand Down
3 changes: 1 addition & 2 deletions pixelmanipulator.js
Expand Up @@ -17,7 +17,7 @@
// Concerning the function commments, # is number, [] means array, {} means object, () means function, true means boolean and, "" means string. ? means optional, seperated with : means that it could be one or the other
(function(g) {
'use strict';
var pxversion="3.2.0";
var pxversion="3.3.0";
function pix(require,exports,module) {//done like this for better support for things like require.js and Dojo
/*function ret(v) {
return (function() {
Expand Down Expand Up @@ -126,7 +126,6 @@
},
__DEAD__:function(elm,binStates,loop) {//In order not to erase the spawner pixels (which are the pixels, usually in the top row that make the pattern appear), erasing on live shouldn't be done.
return (function wdead(rel) {
if (rel.y!==innerP.row) return;//if it is not in the active row, exit before anything happens
for (var binDex=0; binDex<8; binDex++) {//for every possible state
if((binStates&1<<binDex)>0){//if the state is "on". Use a bit mask and shift it
if(rel.wolframNearbyCounter(rel.x,rel.y,elm,binDex,loop)) {//if there is a wolfram match (wolfram code goes from 111 to 000)
Expand Down

0 comments on commit 738b578

Please sign in to comment.