Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include compiled code in version control - use a gh-pages branch or something for that. #60

Closed
Tracked by #53
Lazerbeak12345 opened this issue Feb 21, 2022 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@Lazerbeak12345
Copy link
Owner

No description provided.

@Lazerbeak12345 Lazerbeak12345 mentioned this issue Feb 21, 2022
14 tasks
@Lazerbeak12345 Lazerbeak12345 added the bug Something isn't working label Feb 22, 2022
@Lazerbeak12345 Lazerbeak12345 added this to To do in Convert to typescript via automation Feb 22, 2022
@Lazerbeak12345 Lazerbeak12345 added this to the Version 5 milestone Feb 22, 2022
@Lazerbeak12345 Lazerbeak12345 linked a pull request Feb 22, 2022 that will close this issue
Merged
6 tasks
@Lazerbeak12345
Copy link
Owner Author

gulp-gh-pages seems to be the way to go. TBH I don't 100 percent trust it will do what I want, how I want, so they get a free code review 😉

@Lazerbeak12345
Copy link
Owner Author

Ok, it's exactly what I want. I've just got to set it up now.

@Lazerbeak12345
Copy link
Owner Author

Upon attempt, this is the error message I get:

[17:46:52] TypeError: Cannot read properties of null (reading '0')
    at Function.module.exports.Commit.actor (/home/nate/projects/pixelmanipulator/node_modules/gift/lib/commit.js:145:56)
    at Function.module.exports.Commit.parse_commits (/home/nate/projects/pixelmanipulator/node_modules/gift/lib/commit.js:111:21)
    at /home/nate/projects/pixelmanipulator/node_modules/gift/lib/commit.js:55:39
    at ChildProcess.exithandler (node:child_process:388:7)
    at ChildProcess.emit (node:events:390:28)
    at ChildProcess.emit (node:domain:537:15)
    at maybeClose (node:internal/child_process:1064:16)
    at Socket.<anonymous> (node:internal/child_process:450:11)
    at Socket.emit (node:events:390:28)
    at Socket.emit (node:domain:537:15)

Seeing how delayed the most recent PR is (1 year old) on that repo, I'll just have to find a different solution.

See the gulp-gh-pages branch for where this attempt is at.

@Lazerbeak12345 Lazerbeak12345 moved this from To do to In progress in Convert to typescript Mar 5, 2022
@Lazerbeak12345 Lazerbeak12345 removed a link to a pull request Mar 7, 2022
Merged
6 tasks
Convert to typescript automation moved this from In progress to Done Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

1 participant