feat(notify): enable telescope extension of nvim-notify

[moetayuko]

No description provided.

[dpetka2001]

I don't believe this is needed?? Since opts by default will call the plugin's setup function? Can you test without this line 33 to see if it works?

[moetayuko]

Essentially I tested that in the first place, and custom opts are not applied.

[dpetka2001]

Excuse my ignorance, but how do you test about custom opts being applied?

[moetayuko]

I set my background to be transparent, and nvim-notify throughs a warning every time nvim launches. I have the following piece to suppress it:

  {
    "rcarriga/nvim-notify",
    opts = {
      background_colour = "#000000",
    },
  },

W/o the highlighted lines the warning shows up again.

A more accessible approach might be overriding its default timeout and observing whether the new value gets applied.

[dpetka2001]

It seems that you are right. I changed the value of timeout, that Lazyvim already changes in its opts and I was observing how long it would stay visible. Without setting it up in the config with the opts provided, the notification remained visible for the same amount always. Only when I uncommented setup(opts) inside the config function did I observe a decrease in the amount of time the notification stayed visible. Strange... I thought that opts should be taking care of this step.

[dpetka2001]

I see. It makes sense as you put it. Thanks for your detailed explanation.

[jyuan0]

@abeldekat,

@jyuan0,

You showed interest in this conversation and I read your awesome answer in this #1316 (comment). If you have the time I would be very interested in your thoughts.

Thanks, I was inspired by this awesome thread 😃.

I don't think I really have anything meaningful to add. The three of you have already thoroughly considered the possible implementations. I really appreciate the thought you have all put into lazy-loading, enabled/disabled plugins, and how to best implement things.

Regarding the proposed implementations: I think it makes sense to wait to see if the proposed lazy.nvim changes get merged upstream. This change:

{
    "telescope.nvim",
    opts = function()
      if Util.has("nvim-notify") then
        require("telescope").load_extension("notify")
      end
    end,
    dependencies = {
      {
        "nvim-notify",
        keys = {
          {
            "<leader>sN",
            function()
              require("telescope").extensions.notify.notify()
            end,
            desc = "Search Notifications",
          },
        },
      },
    },
  }

looks preferable to this:

{
        "<leader>unt",
        function()
          if Util.has("telescope.nvim") then
            require("telescope").extensions.notify.notify()
          else
            Util.on_load("which-key.nvim", function()
              require("which-key").register({
                ["<leader>unt"] = "which_key_ignore",
              })
              vim.keymap.del("n", "<leader>unt")
            end)
          end
        end,
        desc = "Open Notifications (Telescope)",
}

I am wondering if it's necessary to register the key with which-key before deleting it, but that's minor and might not even matter if the proposed lazy.nvim changes get upstreamed.

Again, thanks for this awesome conversation and PR review!

[abeldekat]

I created the PR for lazy.nvim, proposing the changes we discussed.

[dpetka2001]

Good luck with your PR 😄

[abeldekat]

@folke improved the PR.
The changes are merged into lazy.nvim v10.4.0!

[moetayuko]

PR updated

[folke]

I just added <leader>snt that opens Noice telescope. It shows a similar view to nvim-notify telescope, but better imho, since it retains the correct message formatting.