Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change the release please action name to new #3259

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Conversation

rubiin
Copy link
Contributor

@rubiin rubiin commented May 21, 2024

https://github.com/google-github-actions/release-please-action is deprecated(more info on the readme) and they suggest using
https://github.com/googleapis/release-please-action.

Also there is no argument called package-name and extra-files which was showing echoing an error on every action run

supported flags are : ['token', 'release-type', 'path', 'target-branch', 'config-file', 'manifest-file', 'repo-url', 'github-api-url', 'github-graphql-url', 'fork', 'include-component-in-tag', 'proxy-server', 'skip-github-release', 'skip-github-pull-request', 'changelog-host']

https://github.com/googleapis/release-please/blob/main/docs/customizing.md#updating-arbitrary-files for extra files

@dpetka2001
Copy link
Contributor

I also see 'extra-files' mentioned in the warnings of Actions, so you might also want to remove that.

But honestly not familiar at all with Github Actions and the maintainer might have some kind of custom setup locally, so he knows best.

@rubiin
Copy link
Contributor Author

rubiin commented May 21, 2024

I also see 'extra-files' mentioned in the warnings of Actions, so you might also want to remove that.

But honestly not familiar at all with Github Actions and the maintainer might have some kind of custom setup locally, so he knows best.

yeah that can be removed as well. Since that option no longer exists on the flags taken by the github action

@folke
Copy link
Collaborator

folke commented May 21, 2024

I don't think it's as simple as this change. If I remember correctly two config files are now also needed.
I've gone through the process for one of my projects, but can't remember which one :)

@rubiin
Copy link
Contributor Author

rubiin commented May 22, 2024

I think the manifest file is only needed when you want to specify next release. And its only used once, this is only used when there is no prior release.
But I will add both of them just in case

@folke folke merged commit 1faa562 into LazyVim:main Jun 5, 2024
1 check passed
@folke
Copy link
Collaborator

folke commented Jun 5, 2024

Merged. Fingers crossed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants