-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(project): add to mini.starter #640
Conversation
Gave a check and couldn't really understand what else it brings that the already installed goolord/alpha-nvim is not able to do. |
It is to support https://github.com/LazyVim/LazyVim/blob/81ab5bed7a81c3005f862d6508dacc26c4ed553a/lua/lazyvim/plugins/extras/ui/mini-starter.lua |
I believe this PR has the same problem I encountered in my own configuration with dependent layers: the For my configuration I had to come up with a HACK-ish workaround so I don't add the specs at all if the parent layer is not loaded: https://github.com/ditsuke/nvim-config/blob/main/lua/ditsuke/utils/lang.lua#L9C3-L11. Now I'm not sure if Lazy already offers a way to tackle this natively, but if not I'd like it if that's done first before we let this one in. |
I just pushed a change to Please add What this does, is it will only add those specs in the final spec if the plugin has been configured somewhere else without the This ensures, that for people not using alpha, or mini.starter, that those plugins won't be automatically installed. |
That is awesome! Should be ready now :) |
Just tested and it all works as expected :) Thanks! |
* feat(project): add to mini.starter * fix(project): make alpha and mini.starter optional
* feat(project): add to mini.starter * fix(project): make alpha and mini.starter optional
I am unsure where to put this, as it sort of belongs to two extras.
What I added here will cause mini.starter to always be loaded if you include the projects extra, right?