locate for all partitions #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazza
reviewed
Jan 11, 2020
Comment on lines
+195
to
+203
| part = check_valid_part(i, parts, shorthands) | ||
| if part is not None: | ||
| results = utils.locate(part, text) | ||
| for node, path in results: | ||
| desc = ( | ||
| ' [GHOST]' if node.is_ghost else | ||
| ' [DELETED]' if node.is_deleted else '' | ||
| ) | ||
| print "partition %s [%s]: %s%s" % (i, node.index, path, desc) |
There was a problem hiding this comment.
I would avoid repetition, if possible. Could you consider moving the common code to a function or similar?
|
Needs rebasing (and some little tweak for py3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #35.
I wrote this a long time ago, and I haven't tested it after rebasing it.
I'd like to post it publicly though for your consideration.