Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .swift_version parameter in podspec #48

Closed
kaygro opened this issue Feb 6, 2019 · 1 comment
Closed

Missing .swift_version parameter in podspec #48

kaygro opened this issue Feb 6, 2019 · 1 comment

Comments

@kaygro
Copy link

kaygro commented Feb 6, 2019

Expected behavior

When integrating this Pod into a Xcode project in swift 4.2, it should compile.

Actual behavior

It does not compile.

Steps to reproduce the behavior

Integrate this Pod into an Xcode project where the main target's swift_version is set to 4.2.

Podspec should just include the .swift_version parameter in podspec.

I just noticed, this pod doesn't take into account the UIKit renamings that occurred in swift 4.2.

@kaygro
Copy link
Author

kaygro commented Feb 6, 2019

I still recommend, putting the swift_version parameter into the podspec.
I noticed, you already migrated the offending classes to swift 4.2. Would you make a new release then?

ItsNotEasyBeingGreen added a commit that referenced this issue Mar 7, 2019
ItsNotEasyBeingGreen added a commit that referenced this issue Mar 7, 2019
choku2908 pushed a commit to choku2908/SimpleImageViewer that referenced this issue May 27, 2019
choku2908 pushed a commit to choku2908/SimpleImageViewer that referenced this issue May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant