Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial revert of PackageReference #191

Merged
merged 2 commits into from
Feb 12, 2018

Conversation

rjmurillo
Copy link
Member

Due to bug NuGet/Home#5979, when creating a NuGet packages, the dependencies are not populated in the generated nupkg file based on PackageReference in csproj (but are if packages.config is present). Since this only impacts projects for redistribution via NuGet, those projects have their PackageReference changes reverted to packages.config

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

Due to bug NuGet/Home#5979, when creating a NuGet packages, the dependencies are not populated in the generated nupkg file based on PackageReference in csproj (but are if packages.config is present). Since this only impacts projects for redistribution via NuGet, those projects have their PackageReference changes reverted to packages.config
@AppVeyorBot
Copy link

Build Qwiq 440 failed (commit 1d0b912f16 by @rjmurillo)

1 similar comment
@AppVeyorBot
Copy link

Build Qwiq 440 failed (commit 1d0b912f16 by @rjmurillo)

@rjmurillo rjmurillo requested a review from a team February 12, 2018 21:42
@rjmurillo rjmurillo self-assigned this Feb 12, 2018
@AppVeyorBot
Copy link

Build Qwiq 443 failed (commit 1d0b912f16 by @rjmurillo)

1 similar comment
@AppVeyorBot
Copy link

Build Qwiq 443 failed (commit 1d0b912f16 by @rjmurillo)

Humanizer is used to "humanize" some test output messages
@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@rjmurillo rjmurillo merged commit be03c6d into LeCantaloop:support/10.0.x Feb 12, 2018
@rjmurillo rjmurillo deleted the hotfix/10.0.1 branch February 12, 2018 22:04
rjmurillo added a commit that referenced this pull request Feb 12, 2018
rjmurillo added a commit that referenced this pull request Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants