-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TFS libs to use NuGet #23
Update TFS libs to use NuGet #23
Conversation
# Conflicts: # Qwiq/Qwiq.Core.Tests/Qwiq.Core.Tests.csproj # Qwiq/Qwiq.Core.Tests/app.config # Qwiq/Qwiq.Core/Qwiq.Core.csproj # Qwiq/Qwiq.Core/app.config # Qwiq/Qwiq.Core/packages.config # lib/TFS/Microsoft.TeamFoundation.Client.dll # lib/TFS/Microsoft.TeamFoundation.Common.dll # lib/TFS/Microsoft.TeamFoundation.Diff.dll # lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Client.DataStoreLoader.dll # lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Client.QueryLanguage.dll # lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Client.dll # lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Common.dll # lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Proxy.dll # lib/TFS/Microsoft.VisualStudio.Services.Client.dll # lib/TFS/Microsoft.VisualStudio.Services.Common.dll # lib/TFS/Microsoft.VisualStudio.Services.WebApi.dll # lib/TFS/Newtonsoft.Json.dll
Correction due to bad merge in 30e0d63
Some projects had direct links to dependent assemblies rather than using the published package version.
New version of assembly contains new types that cannot be Faked. Fake assembly updated after adding types to suppression list.
The JbTfs packages are checked in again |
Per offline: Can we run an experiment to see if WITDatastore is needed with these nuget binaries? Tracked in #24 |
Build failed due to warnings:
|
NuGet packages shouldn't be checked into the repo
This file maps various NuGet configs for projects in the solution. It is an artifact of NuGet and should not be checked in.
Fakes assemblies are generated during the build process for the test and are not required to be part of the repo.
Minor version the core assembly to reflect the new changes.
@MattKotsenas the JB stuff is removed in c2721c1. Regarding the experiment of WITDataStore, there are no integration tests that seem to use the assembly here (they must still be part of Portal). Created #24 to track the experiment. Review status: 0 of 37 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from the review on Reviewable.io |
Fakes assemblies are generated during the build process for the test and are not required to be part of the repo. (reverted from commit 0962327)
Reviewed 34 of 36 files at r1, 4 of 4 files at r2. Comments from the review on Reviewable.io |
@@ -1,10 +0,0 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjmurillo Why is this file removed?
Jenkins please build |
Jenkins please build |
Updated to use WorkItemTracking.Client/Common from NuGet packages rather than local Lib
/cc @MattKotsenas