Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TFS libs to use NuGet #23

Closed
wants to merge 11 commits into from
Closed

Update TFS libs to use NuGet #23

wants to merge 11 commits into from

Conversation

rjmurillo
Copy link
Member

Updated to use WorkItemTracking.Client/Common from NuGet packages rather than local Lib

/cc @MattKotsenas

Review on Reviewable

This task list is updated automatically when the referenced issues are closed or reopened, via

@rjmurillo
Update Qwiq.Core/Qwiq.Tests
0bde499 
Updated to use WorkItemTracking.Client/Common from NuGet packages rather than local Lib

/cc @mattkot
@rjmurillo
Update app.config
8a98c0c 
Add dependentAssembly entry for Microsoft.IdentityModel.Clients.ActiveDirectory

/cc @mattkot
@rjmurillo
Merged 'master'.
30e0d63 
# Conflicts:
#	Qwiq/Qwiq.Core.Tests/Qwiq.Core.Tests.csproj
#	Qwiq/Qwiq.Core.Tests/app.config
#	Qwiq/Qwiq.Core/Qwiq.Core.csproj
#	Qwiq/Qwiq.Core/app.config
#	Qwiq/Qwiq.Core/packages.config
#	lib/TFS/Microsoft.TeamFoundation.Client.dll
#	lib/TFS/Microsoft.TeamFoundation.Common.dll
#	lib/TFS/Microsoft.TeamFoundation.Diff.dll
#	lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Client.DataStoreLoader.dll
#	lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Client.QueryLanguage.dll
#	lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Client.dll
#	lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Common.dll
#	lib/TFS/Microsoft.TeamFoundation.WorkItemTracking.Proxy.dll
#	lib/TFS/Microsoft.VisualStudio.Services.Client.dll
#	lib/TFS/Microsoft.VisualStudio.Services.Common.dll
#	lib/TFS/Microsoft.VisualStudio.Services.WebApi.dll
#	lib/TFS/Newtonsoft.Json.dll
@rjmurillo rjmurillo changed the title Update Qwiq.Core/Qwiq.Tests Update TFS libs to use NuGet Sep 11, 2015
@rjmurillo
Update packages.config, app.config
337c155 
Correction due to bad merge in 30e0d63
@rjmurillo
Update NuGet references
a7b9f25 
Some projects had direct links to dependent assemblies rather than using the published package version.
@rjmurillo
Update WIT.Client fakes
0e3dc05 
New version of assembly contains new types that cannot be Faked. Fake assembly updated after adding types to suppression list.
@rjmurillo rjmurillo self-assigned this Sep 11, 2015
@MattKotsenas
Copy link
Contributor

The JbTfs packages are checked in again

@MattKotsenas
Copy link
Contributor

Per offline: Can we run an experiment to see if WITDatastore is needed with these nuget binaries?

Tracked in #24

@MattKotsenas
Copy link
Contributor

Build failed due to warnings:

"C:\Program Files (x86)\Jenkins\workspace\IEPortal.Qwiq-PRs\Qwiq\Qwiq.sln" (default target) (1) ->
       "C:\Program Files (x86)\Jenkins\workspace\IEPortal.Qwiq-PRs\Qwiq\Qwiq.Identity\Qwiq.Identity.csproj" (default target) (5) ->
       (ResolveAssemblyReferences target) -> 
         C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Common.targets(1605,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "JB.Tfs.Common, Version=0.0.0.5, Culture=neutral, processorArchitecture=MSIL". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [C:\Program Files (x86)\Jenkins\workspace\IEPortal.Qwiq-PRs\Qwiq\Qwiq.Identity\Qwiq.Identity.csproj]


       "C:\Program Files (x86)\Jenkins\workspace\IEPortal.Qwiq-PRs\Qwiq\Qwiq.sln" (default target) (1) ->
       "C:\Program Files (x86)\Jenkins\workspace\IEPortal.Qwiq-PRs\Qwiq\Qwiq.Core\Qwiq.Core.csproj" (default target) (2) ->
         C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Common.targets(1605,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "JB.Tfs.Common, Version=0.0.0.5, Culture=neutral, processorArchitecture=MSIL". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [C:\Program Files (x86)\Jenkins\workspace\IEPortal.Qwiq-PRs\Qwiq\Qwiq.Core\Qwiq.Core.csproj]

@rjmurillo rjmurillo assigned MattKotsenas and unassigned rjmurillo Sep 12, 2015
@rjmurillo
Removing JB.Tfs.Common
c2721c1 
NuGet packages shouldn't be checked into the repo
@rjmurillo
Remove repositories.config
e70ab5e 
This file maps various NuGet configs for projects in the solution. It is an artifact of NuGet and should not be checked in.
@rjmurillo
Remove Fakes assemblies
0962327 
Fakes assemblies are generated during the build process for the test and are not required to be part of the repo.
@rjmurillo
Update AssemblyInfo.cs
d3376cc 
Minor version the core assembly to reflect the new changes.
@rjmurillo rjmurillo mentioned this pull request Sep 12, 2015
Closed
@rjmurillo
Copy link
Member Author

@MattKotsenas the JB stuff is removed in c2721c1. Regarding the experiment of WITDataStore, there are no integration tests that seem to use the assembly here (they must still be part of Portal). Created #24 to track the experiment.

Review status: 0 of 37 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io

@rjmurillo
Remove Fakes assemblies
213ae39 
Fakes assemblies are generated during the build process for the test and are not required to be part of the repo. (reverted from commit 0962327)
@rjmurillo
Copy link
Member Author

Reviewed 34 of 36 files at r1, 4 of 4 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

MattKotsenas
MattKotsenas reviewed Sep 14, 2015
View reviewed changes
Qwiq/packages/repositories.config
@@ -1,10 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjmurillo Why is this file removed?

@rjmurillo rjmurillo added this to the Future milestone Oct 9, 2015
@rjmurillo rjmurillo removed the story label Nov 11, 2015
@rjmurillo
Copy link
Member Author

Jenkins please build

@rjmurillo rjmurillo added reviewing and removed doing labels Dec 16, 2015
@rjmurillo
Copy link
Member Author

Jenkins please build

@rjmurillo
Copy link
Member Author

Fixed in #44 and #45

@rjmurillo rjmurillo closed this Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rjmurillo rjmurillo

Labels
None yet
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjmurillo @MattKotsenas