Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

big code refactor and tools update #23

Merged
merged 12 commits into from
Oct 16, 2018
Merged

big code refactor and tools update #23

merged 12 commits into from
Oct 16, 2018

Conversation

danielpza
Copy link
Contributor

@danielpza danielpza commented Oct 13, 2018 •
edited by davidpa9708

Features

  • add onScroll functions

Misc

  • add semantic-release
  • improve readme
  • remove demo
  • refactor tests

davidpa9708 and others added 6 commits October 13, 2018 19:48
@davidpa9708 @danielpza
Move scroll distance to ScrollElement
d1c80ce 
Signed-off-by: David Perez Alvarez <david@leddgroup.com>
@davidpa9708 @danielpza
Remove tslint
69a68d8 
Signed-off-by: David Perez Alvarez <david@leddgroup.com>
@davidpa9708 @danielpza
update readme
5d4a984 
Signed-off-by: David Perez Alvarez <david@leddgroup.com>
@davidpa9708 @danielpza
Update exported scroll functions
87d8508 
Signed-off-by: David Perez Alvarez <david@leddgroup.com>
@davidpa9708 @danielpza
Change onScroll
a81c1c4 
Signed-off-by: David Perez Alvarez <david@leddgroup.com>
@danielpza
build: add useful packages
fc9c2c0 
- prettier, pretty-quick
- husky
- commitlint
- semantic-release
davidpa9708 and others added 2 commits October 13, 2018 20:52
@davidpa9708 @danielpza
refactor: update code, tests, tools, style, config
bf09128 
- add tsconfig and fix some strict errors
- use parcel for development
- remove bundle and demo
- use jest for tests

Signed-off-by: David Perez Alvarez <david@leddgroup.com>
@danielpza
ci: test on node 8 only
78947fb
This was referenced Oct 14, 2018
Closed
Closed
@davidpa9708
Copy link
Contributor

davidpa9708 commented Oct 14, 2018 •
edited

Todo:

  • Improve tests accuracy (remove closeTo asserts).
  • Add main and browser version and check download requirements in jsdeliver~
  • ? Add tests for Opera browser (browserstack/macos/opera)
  • Update readme (see Demo is not working #22)

@davidpa9708 davidpa9708 merged commit 009ee85 into master Oct 16, 2018
@davidpa9708 davidpa9708 deleted the dev branch October 16, 2018 16:30
@danielpza
Copy link
Contributor Author

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@davidpa9708 davidpa9708 mentioned this pull request Oct 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidpa9708 davidpa9708 davidpa9708 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielpza @davidpa9708