Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trim slider from controller #141

Merged
merged 5 commits into from
Feb 27, 2023
Merged

Conversation

LeGoffMael
Copy link
Owner

Fix issue mentioned in #139, trim slider is now updated when trim values are updated programmatically.

❌ Removed setters minTrim, maxTrim, minCrop & maxCrop
✍️ Renamed updateCrop() into applyCacheCrop()
🎉New updateCrop(double min, double max) to update crop values programmatically.

jsenaassa and others added 5 commits February 10, 2023 20:43
Added optional param for scrollController
- prefer using `updateTrim` or `updateCrop` instead
- renamed misleading `updateCrop` into `applyCacheCrop`
- add assert to ensure update params are correct
@LeGoffMael LeGoffMael merged commit 93db17c into master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants