Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New trimmer when video duration > maxDuration parameter #27

Merged
merged 15 commits into from Jul 31, 2021
Merged

New trimmer when video duration > maxDuration parameter #27

merged 15 commits into from Jul 31, 2021

Conversation

LeGoffMael
Copy link
Owner

It would be nice to have a different type of trimmer if the video duration is greater than the maxDuration parameter.

🚀 New feature

  • new trimmer style when the length of the video is greater than maxDuration
    • inside gesture scroll horizontally to change the maxDuration trim position in the video length
    • inside gesture update progress position and video seek position

🐛 Trimmer improvments

  • avoid maxTrim to be smaller than minTrim in TrimSlider
  • avoid minTrim to be bigger than maxTrim in TrimSlider

General changes

  • maxDuration is now a parameter of the VideoEditorController class
  • Horizontal margin must be a parameter of the TrimSlider widget

Mael Le Goff and others added 15 commits July 26, 2021 16:21
[config] add Flutter Version Management FVM config
7b00ec0
[info] update readme.md
f7b5ce3
[info] update readme.md
cda30ee
[feature] new style trimmer when max duration < video duration
07c45ff
[feature] set maxDuration in controller in example
71ab7aa
@LeGoffMael
[change] add safeArea in example for >= iPhone X screen
b3506c7
@LeGoffMael
[fix] avoid minTrim to be bigger than maxTrim + avoid maxTrim to be s…
0866b33 
…maller than minTrim
@LeGoffMael
[readme] update readme
04de26a
[feature] add padding to see next and previous thumbnails when videoD…
0cec37f 
…uration > maxDuration
[fix] fix width of trimmer when videoDuration < maxDuration
c1b84db
[example] remove unnecessary safearea param
85ed743
[readme] add new trimmer gif
0353900
[change] clean repo for pull request
0231753
[clean] remove unnecessary files
d4529ba
[readme] update readme
9f1272c
@LeGoffMael LeGoffMael changed the title Pull request new trimmer New trimmer when video duration > maxDuration parameter Jul 29, 2021
@seel-channel
Copy link
Collaborator

Thank a bunch! Brother :)

@seel-channel seel-channel merged commit e9ccde5 into LeGoffMael:master Jul 31, 2021
@LeGoffMael LeGoffMael mentioned this pull request Aug 2, 2021
Merged
@LeGoffMael
Copy link
Owner Author

this pull request should have fixed the issue #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeGoffMael @seel-channel