Improve cover exportation + apply cover quality in thumbnail #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… always the same than the preview (some 3ms with ffmpeg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoverSelection.ffmpegto generate the cover image, the result image could be different to the one selected withVideoThumbnaillibrary even when using the same time position. It is becauseffmpeguses keyframes to seek to the video position (source) so the position is not accurate (i noticed difference up to 4ms). By usingVideoThumbnaillibrary to generate the cover and then usingffmpegto transform the image the issue is fixed.read.me. app is getting crash in release mode #41 (comment)